GIVbacks notification is misleading

[WhyldWanderer]

People are confused because the notification says they have a certain amount to claim, but when they click the link to go to the claim page, the number does not match.

We should figure out a way to communicate to the user that only a certain percentage is claimable right away and the rest will be streamed to them.

[divine-comedian]

I think this is a back-end issue, who can take it? @CarlosQ96 @mohammadranjbarz

We should make it simple and change the notification to read:

"You have GIVbacks waiting to be claimed!"

[divine-comedian]

passing this one to @RamRamez

[RamRamez]

@Reshzera could you please take it?

[Reshzera]

@RamRamez Yes, I'll take a look

[Reshzera]

@maryjaf @LatifatAbdullahi This Issue is ready to be tested on the staging, could you please take a look?

[maryjaf]

@maryjaf @LatifatAbdullahi This Issue is ready to be tested on the staging, could you please take a look?

I think the giveback should be set manually for my user that I could be able to check the notification
0xcd192b61a8Dd586A97592555c1f5709e032F2505

0xD5db3F8B0a236176587460dC85F0fC5705D78477

[divine-comedian]

0xD5db3F8B0a236176587460dC85F0fC5705D78477

I sent you some GIVbacks manually but I'm not sure if it's enough to trigger the notification...

[maryjaf]

0xD5db3F8B0a236176587460dC85F0fC5705D78477

I sent you some GIVbacks manually but I'm not sure if it's enough to trigger the notification...

Thanks @divine-comedian
But I haven't received any notification related to givback

[RamRamez]

@ae2079 could you please help @Reshzera and @maryjaf for testing this issue?

[ae2079]

@ae2079 could you please help @Reshzera and @maryjaf for testing this issue?

Sure

[ae2079]

I use this data:

{
  "eventName": "GIVback is ready to claim",
  "sendEmail": false,
  "sendSegment": false,
  "userWalletAddress": "0x85A2779454C0795714cA50080b67F6aCf453F264",
  "metadata": {
    "contractName": "Gnosis Chain Token Distro",
    "transactionHash": "testTransactionHash",
    "network": 100,
    "amount": "10"
  }
}

and send a request to this URL: https://notification.serve.giveth.io/v1/thirdParty/notifications
and get this error:

{
    "message": "Notification type is invalid",
    "httpStatusCode": 400
}

I'll try to debug it locally (maybe I missed some fields of data)

[divine-comedian]

I use this data:

{
  "eventName": "GIVback is ready to claim",
  "sendEmail": false,
  "sendSegment": false,
  "userWalletAddress": "0x85A2779454C0795714cA50080b67F6aCf453F264",
  "metadata": {
    "contractName": "Gnosis Chain Token Distro",
    "transactionHash": "testTransactionHash",
    "network": 100,
    "amount": "10"
  }
}

and send a request to this URL: https://notification.serve.giveth.io/v1/thirdParty/notifications and get this error:

{
    "message": "Notification type is invalid",
    "httpStatusCode": 400
}

I'll try to debug it locally (maybe I missed some fields of data)

OK - also coordinate with @Reshzera as needed. since he made the migration updating the notification.

[ae2079]

The previous error was related to the header that I used another microservice secret and it works after changing it to giveconomy-notification-service.
another problem that I face with it now, is related to migration execution errors on staging:

and because of that, I got the wrong message (previous version):

[ae2079]

after fixing the data manually, it works
(we have a migration execution problem that is not related to changes in this issue)

[divine-comedian]

Thanks for debugging that @ae2079 - so the screenshot above is from staging? If so we can say this feature has passed QA.

[maryjaf]

Thanks @ae2079, it has been fixed

[ae2079]

Thanks for debugging that @ae2079 - so the screenshot above is from staging? If so we can say this feature has passed QA.

you're welcome, yes it is from staging, but the migration issue remains and I'm working on that. (To deploy it on production, we need to fix this problem first)

[ae2079]

Thanks for debugging that @ae2079 - so the screenshot above is from staging? If so we can say this feature has passed QA.

you're welcome, yes it is from staging, but the migration issue remains and I'm working on that. (To deploy it on production, we need to fix this problem first)

@divine-comedian
Now, the migration issue is fixed and we can deploy it whenever you want

[divine-comedian]

great! we should make sure we include it in our next general release for the FE and BE

[maryjaf]

It seems this change hasn't been deployed on prod yet
I've commented only for kindly remind this for next release

[divine-comedian]

@ae2079 does this require a release on the notification-center repo?

I think our last release was on July 21 so this might have not been included in the impact-graph release

[ae2079]

@ae2079 does this require a release on the notification-center repo?

I think our last release was on July 21 so this might have not been included in the impact-graph release

yeah, it is on the notification center

[divine-comedian]

OK if this doesn't need a release on the impact-graph can we make a release for this repo?

[ae2079]

OK if this doesn't need a release on the impact-graph can we make a release for this repo?

@RamRamez

[divine-comedian]

@ae2079 @RamRamez can we confirm that we made a release on notification center to production? if so we can close this one.

[RamRamez]

@divine-comedian last week we didn't make a release on notification center to production, but the PR related to this issue is on production