Skip to content

Revert "fix(release): synchronize web changelog entries" - #2113

Merged
kevincodex1 merged 1 commit into
mainfrom
revert-2088-fix/release-web-sync
Aug 11, 2026
Merged

kevincodex1 merged 1 commit into
mainfrom
revert-2088-fix/release-web-sync

Conversation

@jatmn

@jatmn jatmn commented Aug 11, 2026 •

Copy link
Copy Markdown
Collaborator

Reverts #2088

Summary by CodeRabbit

  • Release Process

    • Simplified release automation and removed draft-release handling.
    • Removed automatic synchronization of web release entries and related validation.
  • Documentation

    • Updated release highlights to reflect manual curation.
    • Revised changelog metadata and introductory text accordingly.
  • Chores

    • Removed obsolete release synchronization commands and configuration.

@jatmn

jatmn commented Aug 11, 2026

Copy link
Copy Markdown
Collaborator Author

@kevincodex1 revert

@coderabbitai

coderabbitai Bot commented Aug 11, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: b38bbd6b-e324-4ff8-a554-e77e0be3850c

📥 Commits

Reviewing files that changed from the base of the PR and between 16e332e and dcccb5e.

📒 Files selected for processing (8)
  • .github/workflows/release.yml
  • CONTRIBUTING.md
  • package.json
  • release-please-config.json
  • scripts/sync-web-release-entry.test.ts
  • scripts/sync-web-release-entry.ts
  • web/src/data/releases.ts
  • web/src/pages/changelog.astro
💤 Files with no reviewable changes (5)
  • CONTRIBUTING.md
  • package.json
  • release-please-config.json
  • scripts/sync-web-release-entry.test.ts
  • scripts/sync-web-release-entry.ts
📜 Recent review details
⏰ Context from checks skipped due to timeout. (5)
  • GitHub Check: smoke-and-tests (24.11.x)
  • GitHub Check: typecheck
  • GitHub Check: smoke-and-tests (22)
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: Analyze (javascript-typescript)
🧰 Additional context used
📓 Path-based instructions (8)
**/*

⚙️ CodeRabbit configuration file

**/*: Apply the OpenClaude maintainer review rubric from AGENTS.md. Review the current diff, not stale discussion context. Separate real blockers from suggestions. Do not request changes for vague style churn. Treat approval as merge-ready from CodeRabbit's side, pending required human review and GitHub Checks. If checks are failing or unavailable, say so clearly instead of implying the PR is fully ready.

Files:

  • web/src/pages/changelog.astro
  • web/src/data/releases.ts
web/**

⚙️ CodeRabbit configuration file

web/**: Review browser extension changes for content-script isolation, message validation, cross-origin assumptions, permission surfaces, and failures that could leak prompts or credentials.

Files:

  • web/src/pages/changelog.astro
  • web/src/data/releases.ts
**/*.{ts,tsx}

📄 CodeRabbit inference engine (AGENTS.md)

Use TypeScript strict mode and ESM imports throughout the source code.

Run relevant TypeScript type checks, including bun run typecheck and bun run typecheck:type-tests, for changes covered by the dedicated typecheck CI job.

Files:

  • web/src/data/releases.ts
**/*.{tsx,ts}

📄 CodeRabbit inference engine (AGENTS.md)

Use React and Ink patterns for terminal UI components.

Files:

  • web/src/data/releases.ts
web/**/*.{ts,tsx}

📄 CodeRabbit inference engine (AGENTS.md)

When changing the web application, run the web typecheck and build checks.

When changing the web application, run bun run web:typecheck and bun run web:build.

Files:

  • web/src/data/releases.ts
web/src/data/releases.ts

📄 CodeRabbit inference engine (AGENTS.md)

Do not edit web/src/data/releases.ts in ordinary feature or bugfix PRs; it is owned by the release/web process.

Do not edit web/src/data/releases.ts in ordinary feature or bug-fix work; only edit it in an explicit release/web changelog change.

Files:

  • web/src/data/releases.ts
**/*.{ts,tsx,js,jsx}

📄 CodeRabbit inference engine (AGENTS.md)

Do not add new Python code, Python provider paths, or Python dependencies without explicit maintainer approval.

Review AI-generated or assisted code for correctness beyond compilation, style consistency, unnecessary changes, and adherence to existing architecture and patterns.

Files:

  • web/src/data/releases.ts
.github/**

⚙️ CodeRabbit configuration file

.github/**: Review CI and release workflow changes for token permissions, third-party actions, pull_request_target usage, artifact upload/download behavior, shell injection, and whether checks still run on the actual PR head. Block on broadened write permissions or unpinned/excessively trusted external execution unless clearly justified.

Files:

  • .github/workflows/release.yml
🧠 Learnings (1)
📓 Common learnings
Learnt from: CR
Repo: Gitlawb/openclaude

Timestamp: 2026-08-11T12:16:40.975Z
Learning: Read `CONTRIBUTING.md` and `AGENTS.md` before opening a pull request, and follow repository-specific conventions and validation commands.
Learnt from: CR
Repo: Gitlawb/openclaude

Timestamp: 2026-08-11T12:16:40.975Z
Learning: Keep pull requests focused on one issue or one clearly scoped improvement; do not mix unrelated fixes, cleanup, features, or refactors.
Learnt from: CR
Repo: Gitlawb/openclaude

Timestamp: 2026-08-11T12:16:40.975Z
Learning: Preserve existing repository patterns unless intentionally refactoring them, and prefer small, readable changes over broad rewrites.
Learnt from: CR
Repo: Gitlawb/openclaude

Timestamp: 2026-08-11T12:16:40.975Z
Learning: Add or update tests when a change affects behavior, and update documentation when setup, commands, or user-facing behavior changes.
Learnt from: CR
Repo: Gitlawb/openclaude

Timestamp: 2026-08-11T12:16:40.975Z
Learning: For provider changes, review the integration overview and relevant focused how-to guides before implementation, follow documented provider patterns, and test the exact provider/model path changed when possible.
Learnt from: CR
Repo: Gitlawb/openclaude

Timestamp: 2026-08-11T12:16:40.975Z
Learning: Provider changes must avoid breaking third-party providers, identify affected providers, document limitations or follow-up work, and must not assign or use provider tags because maintainers control them.
Learnt from: CR
Repo: Gitlawb/openclaude

Timestamp: 2026-08-11T12:16:40.975Z
Learning: Run the narrowest meaningful validation for the touched area, and do not submit changes that fail required CI checks.
Learnt from: CR
Repo: Gitlawb/openclaude

Timestamp: 2026-08-11T12:16:40.975Z
Learning: Use `bun install` to install dependencies and the documented Bun commands for building, smoke testing, full checks, provider tests, and diagnostics as applicable.
Learnt from: CR
Repo: Gitlawb/openclaude

Timestamp: 2026-08-11T12:16:40.975Z
Learning: Dependency changes must have a concrete project benefit, such as fixing a bug, addressing a security issue, or supporting an approved feature; preference alone is insufficient.
Learnt from: CR
Repo: Gitlawb/openclaude

Timestamp: 2026-08-11T12:16:40.975Z
Learning: Do not change the project's language, core runtime, dependency stack, or significantly restructure dependencies without prior maintainer agreement.
Learnt from: CR
Repo: Gitlawb/openclaude

Timestamp: 2026-08-11T12:16:40.975Z
Learning: PR descriptions must explain what changed and why, user or developer impact, exact checks run, linked issues when applicable, screenshots for UI/terminal/VS Code changes, and the tested provider path for provider changes.
🪛 zizmor (1.29.0)
.github/workflows/release.yml

[warning] 18-18: permissions without explanatory comments (undocumented-permissions): needs an explanatory comment

(undocumented-permissions)

🔇 Additional comments (5)
.github/workflows/release.yml (2)

17-19: LGTM!


20-30: 🗄️ Data Integrity & Integration

No stale release_pr reference exists. Downstream jobs use the retained release_created, tag_name, and version outputs.

			> Likely an incorrect or invalid review comment.
web/src/data/releases.ts (1)

1-3: LGTM!

web/src/pages/changelog.astro (2)

7-7: LGTM!

Also applies to: 35-35


7-7: 📐 Maintainability & Code Quality

Report the web validation commands in the PR description.

AGENTS.md requires web checks for web changes. Run bun run web:typecheck and bun run web:build, then record the exact commands and results in the PR description. The current description lists only the revert reference.

As per path instructions: "Run focused validation, plus web checks for web changes (for example, bun run web:typecheck and bun run web:build), and report exact commands in the PR."

Sources: Path instructions, Learnings


📝 Walkthrough

Walkthrough

The PR removes web release synchronization from the workflow, scripts, tests, configuration, and documentation. It configures Release Please for Node releases and updates the web changelog to describe manually curated highlights.

Changes

Release automation and curated changelog

Layer / File(s) Summary
Release workflow simplification
.github/workflows/release.yml, release-please-config.json, package.json, scripts/sync-web-release-entry.ts, scripts/sync-web-release-entry.test.ts, CONTRIBUTING.md
The workflow removes draft-management and web synchronization jobs. The synchronization script, tests, npm command, draft configuration, and related documentation are deleted. Release Please receives write permissions and uses the Node release type.
Curated release presentation
web/src/data/releases.ts, web/src/pages/changelog.astro
Release data and changelog text now describe hand-picked highlights instead of automation-selected or quick summaries.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Possibly related PRs

Suggested labels: bug

Suggested reviewers: kevincodex1

🚥 Pre-merge checks | ✅ 5 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description only states the reverted pull request and omits the required summary, impact, testing, and notes sections. Add the template sections with the reason for the revert, user and maintainer impact, test results, and known limitations.
Risk Surface Disclosed ⚠️ Warning The PR description only says it reverts #2088; it does not mention CI write permissions, release automation changes, or whether the revert introduces a blocker. Add a risk section that names the CI permissions and release workflow/script changes, then state explicitly whether the revert introduces a blocker.
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies this changeset as a revert of the release synchronization change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
No Hidden Policy Change ✅ Passed The patch is scoped to release automation and web changelog maintenance; it explicitly reverts #2088, with no product, routing, telemetry, network, or unrelated permission-policy changes.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch revert-2088-fix/release-web-sync

Comment @coderabbitai help to get the list of available commands.

@jatmn jatmn self-assigned this Aug 11, 2026
@jatmn jatmn added the bug Something isn't working label Aug 11, 2026
@kevincodex1
kevincodex1 merged commit 5f8e7d1 into main Aug 11, 2026
10 checks passed
@jatmn
jatmn deleted the revert-2088-fix/release-web-sync branch August 11, 2026 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants