Add GitHub issues integration #1079
Conversation
|
commit: |
spastorelli
force-pushed
the
steeve/github-issues-integration
branch
from
403348c to
5075da7
Compare
spastorelli
force-pushed
the
steeve/github-issues-integration
branch
from
5075da7 to
571bc06
Compare
| WEBHOOK_SECRET: ${{ env.GITHUB_WEBHOOK_SECRET }} | ||
| target: organization | ||
| envs: | ||
| dev-steeve: |
There was a problem hiding this comment.
Need to create the GitHub apps for the other environments (prod/staging) but don't have the necessary permission on the GitBookIO GitHub organization.
I will update the manifest once the apps are created or have the corresponding entries in 1Password.
| summary: | | ||
| # Overview | ||
| Automatically get AI-suggested change requests for your docs based on feedback from your GitHub Issues. |
There was a problem hiding this comment.
I will work on the description/assets in another PR.
There was a problem hiding this comment.
@addisonschultz can you help there in another PR once it's merged?
| # GitHub | ||
| GITHUB_APP_INSTALL_URL: ${{ secrets.GITBOOK_GITHUB_APP_INSTALL_URL }} | ||
| GITHUB_APP_ID: ${{ secrets.GITBOOK_GITHUB_APP_ID }} | ||
| GITHUB_APP_NAME: ${{ secrets.GITHUB_APP_NAME }} |
There was a problem hiding this comment.
What is this?
Should it be a 1password entry now? we should avoid secrets
| const response = await octokit.request('GET /installation/repositories', { | ||
| per_page: 100, | ||
| headers: { | ||
| 'X-GitHub-Api-Version': GITHUB_API_VERSION, |
There was a problem hiding this comment.
Why do you need to pass this?
Isn't octokit doing it already?
| @@ -0,0 +1,2 @@ | |||
| export const GITBOOK_INTEGRATION_USER_AGENT = 'GitBook-GitHub-Issues-Integration'; | |||
| export const GITHUB_API_VERSION = '2022-11-28'; | |||
There was a problem hiding this comment.
There is no newer version ? :D
| metadata: { | ||
| url: issue.url, | ||
| attributes: { | ||
| source: 'github-issues', |
There was a problem hiding this comment.
I'm not sure you need this; as the source is auto-set from the integraiton name
| summary: | | ||
| # Overview | ||
| Automatically get AI-suggested change requests for your docs based on feedback from your GitHub Issues. |
There was a problem hiding this comment.
@addisonschultz can you help there in another PR once it's merged?
This PR aims to add the GitHub issues integration.
Part https://linear.app/gitbook-x/issue/RND-8917/add-github-issues-integration