Skip to content

Commit 3e31638

Browse files
committed
Add consistent checking of first dark then light asset
1 parent d7a6ab5 commit 3e31638

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

packages/gitbook/src/components/PageBody/useCoverPosition.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,8 @@ export function useCoverPosition(imgs: Images, y: number) {
3737

3838
// Load original image dimensions if not provided in `imgs`
3939
useLayoutEffect(() => {
40-
// Check if we have dimensions from either light or dark image
41-
const hasDimensions = imgs.light.size || imgs.dark?.size;
40+
// Check if we have dimensions from dark (if provided) or else the default light.
41+
const hasDimensions = imgs.dark?.size || imgs.light.size;
4242

4343
if (hasDimensions) {
4444
return; // Already have dimensions
@@ -65,8 +65,8 @@ export function useCoverPosition(imgs: Images, y: number) {
6565
}, [imgs.light, imgs.dark]);
6666

6767
// Use provided dimensions or fall back to loaded dimensions
68-
// Check light first, then dark, then loaded dimensions
69-
const imageDimensions = imgs.light.size ?? imgs.dark?.size ?? loadedDimensions;
68+
// Check dark first, then light, then loaded dimensions
69+
const imageDimensions = imgs.dark?.size ?? imgs.light.size ?? loadedDimensions;
7070

7171
// Calculate ratio and dimensions similar to useCoverPosition hook
7272
const ratio =

0 commit comments

Comments
 (0)