-
Notifications
You must be signed in to change notification settings - Fork 662
Add BuildKite build agent #2957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Not sure what's going on with the documentation part of the build...any ideas @asbjornu ? |
|
@aidenhaak, good question. There's nothing in this PR that should cause the "Could not find module |
|
@asbjornu it seems it's the [Remark Linting] step in the docs that are failing. If I remember correctly that was added by you some time ago as part of the docs validation. Can you check that? |
|
Yeah, I noticed that. I just can't think of a reason for it to suddenly stop working. I'll have a look. |
asbjornu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aidenhaak, the build is now successful, but there are a few nitpicks pointed out by Reviewdog that would be great if you could fix. 🙏🏼
|
@asbjornu fixed! Worth squashing |
asbjornu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aidenhaak, awesome! No squashing needed. :)
|
Thank you @aidenhaak for your contribution! |
Merge pull request #2957 from aidenhaak/feature/buildkite Add BuildKite build agent
Description
Added a Buildkite build agent so that GitVersion can use the
BUILDKITE_BRANCHenvironment variable when running on a Buildkite agent.Related Issue
Resolves #2956.
Motivation and Context
By default Buildkite checkout a branch in a headless state. This change removes the need for adding this at the start of a Buildkite pipeline:
How Has This Been Tested?
Please note I wasn't able to check my added documentation is valid as I got this error trying to run the build script:
Checklist: