Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move dependencies to Maven #131

Closed
Kiran-Rao opened this issue May 11, 2021 · 8 comments
Closed

Move dependencies to Maven #131

Kiran-Rao opened this issue May 11, 2021 · 8 comments

Comments

@Kiran-Rao
Copy link

Kiran-Rao commented May 11, 2021

Hello, Jcenter is shutting down soon. The following dependencies appear to be relying on jcenter:

|    +--- io.alterac.blurkit:blurkit:1.1.1 FAILED
|    +--- com.facebook.fresco:fresco:2.4.0 FAILED
|    +--- com.facebook.fresco:animated-gif:2.4.0 FAILED
|    +--- com.facebook.fresco:animated-base:2.4.0 FAILED
|    +--- com.facebook.fresco:animated-drawable:2.4.0 FAILED
|    +--- com.facebook.fresco:animated-webp:2.4.0 FAILED
|    +--- com.facebook.fresco:webpsupport:2.4.0 FAILED
|    +--- com.facebook.fresco:imagepipeline-okhttp3:2.4.0 FAILED
@Kiran-Rao Kiran-Rao changed the title Move out the library from Jcenter Move dependencies to JCenter May 11, 2021
@Kiran-Rao Kiran-Rao changed the title Move dependencies to JCenter Move dependencies to Maven May 11, 2021
@Kiran-Rao
Copy link
Author

Kiran-Rao commented May 11, 2021

Related: facebook/fresco#2603
Related: CameraKit/blurkit-android#76

@ALexanderLonsky
Copy link
Collaborator

hey @Kiran-Rao, thank you for flagging this.
We are aware of those dependencies and it is on our roadmap.
As you mentioned, the latest Fresco version is not on Maven yet.

@oprisnik
Copy link

oprisnik commented Jun 9, 2021

Hey! We've released Fresco 2.5.0 tot Maven Central, so you should be able to upgrade now.

@ALexanderLonsky
Copy link
Collaborator

ALexanderLonsky commented Jun 9, 2021

@oprisnik hey! thank you for the update, we'll do that soon.

@gildor
Copy link

gildor commented Jun 10, 2021

@ALexanderLonsky Is there any chance that something will be done also with blurkit (related issue, looks that no migration is planned)? For now, Giphy is the only library which we use which depends on jcenter dependencies

@ALexanderLonsky
Copy link
Collaborator

@gildor of course, I thought just to remove it, because there are more issues with that library like crashes and memory leaks.

@ALexanderLonsky
Copy link
Collaborator

@Kiran-Rao, @gildor
The issue must be fixed in v2.1.1

@Kiran-Rao
Copy link
Author

Thanks @ALexanderLonsky, v2.1.1 appears to have solved this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants