Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smithing tables from before 1.20 are unusable #3866

Closed
Arqui9897 opened this issue Jun 13, 2023 · 21 comments · Fixed by #4056
Closed

Smithing tables from before 1.20 are unusable #3866

Arqui9897 opened this issue Jun 13, 2023 · 21 comments · Fixed by #4056
Labels
Confirmed Bug The bug reported is confirmed and able to be replicated.

Comments

@Arqui9897
Copy link

Describe the bug

The Smithing Table is not working since java and bedrock in the latest build of geyser bulid #182 and updating Floodgate build #59 this in paper/spigot when interacting with the smithing table makes the click animation several times like about 6

To Reproduce

It's quite simple, it's just interacting with the Smithing Table, it doesn't work in bedrock or java

Expected behaviour

normal behavior The Smithing Table

Screenshots / Videos

https://youtu.be/1jy27oHDV1s

Server Version and Plugins

server host 1.19.2 using viaversion #4.7.0 compatibility until reaching 1.20

Geyser Dump

https://dump.geysermc.org/smaY6ta9Hzdtx26hBF82seXRi1H81pv3

Geyser Version

geyser bulid #182

Minecraft: Bedrock Edition Device/Version

minecraft windows, movil y minecraft java

Additional Context

I think it's the geyser because before updating the plugin it worked and after updating to a previous build of geyser that I'm reporting it works in java but not in bedrock now that I update to this version that I'm reporting java and bedrock no longer work

@Konicai
Copy link
Member

Konicai commented Jun 13, 2023

This has been fixed in ViaVersion 4.7.1-SNAPSHOT: https://ci.viaversion.com/job/ViaVersion-DEV/

@Konicai Konicai closed this as not planned Won't fix, can't repro, duplicate, stale Jun 13, 2023
@Konicai Konicai added Suspected Server Behavior This probably isn't a Geyser bug but rather something the server is doing. Duplicate The issue is a duplicate of another. labels Jun 13, 2023
@MrBsng
Copy link

MrBsng commented Jun 13, 2023

This has been fixed in ViaVersion 4.7.1-SNAPSHOT: https://ci.viaversion.com/job/ViaVersion-DEV/

it is not, they're using the furnace gui but bedrock has a client limitation where you can't put the netherite ingot in the fuel slot.
I'm taking it upon myself to edit the one nbt value and try out different gui's and find one that would work on bedrock.

@FlorianMichael
Copy link

This has been fixed in ViaVersion 4.7.1-SNAPSHOT: https://ci.viaversion.com/job/ViaVersion-DEV/

it is not, they're using the furnace gui but bedrock has a client limitation where you can't put the netherite ingot in the fuel slot. I'm taking it upon myself to edit the one nbt value and try out different gui's and find one that would work on bedrock.

Maybe we could go with an Anvil GUI?

@onebeastchris
Copy link
Member

Anvil GUI likely would not work due to a client limitation where we cannot influence the outcome.
Seeing that this issue is still there due to the geyser bug with the Via workaround, i'll reopen this

@onebeastchris onebeastchris reopened this Jun 14, 2023
@onebeastchris onebeastchris added Confirmed Bug The bug reported is confirmed and able to be replicated. and removed Duplicate The issue is a duplicate of another. Suspected Server Behavior This probably isn't a Geyser bug but rather something the server is doing. labels Jun 14, 2023
@Konicai Konicai changed the title The Smithing Table Smithing tables from before 1.20 are unusable Jun 14, 2023
@MrBsng
Copy link

MrBsng commented Jun 14, 2023

Anvil GUI likely would not work due to a client limitation where we cannot influence the outcome. Seeing that this issue is still there due to the geyser bug with the Via workaround, i'll reopen this

I think Anvil GUI would work, I don't know the nbt number for it though whereas the viaversion devs do. But i'm going through random gui menu's now until i could find that one.

Edit: no other gui's work

@FlorianMichael
Copy link

Anvil GUI likely would not work due to a client limitation where we cannot influence the outcome. Seeing that this issue is still there due to the geyser bug with the Via workaround, i'll reopen this

I think Anvil GUI would work, I don't know the nbt number for it though whereas the viaversion devs do. But i'm going through random gui menu's now until i could find that one.

I can build you a ViaVersion jar with the anvil as gui if you want

@MrBsng
Copy link

MrBsng commented Jun 14, 2023

Anvil GUI likely would not work due to a client limitation where we cannot influence the outcome. Seeing that this issue is still there due to the geyser bug with the Via workaround, i'll reopen this

I think Anvil GUI would work, I don't know the nbt number for it though whereas the viaversion devs do. But i'm going through random gui menu's now until i could find that one.

I can build you a ViaVersion jar with the anvil as gui if you want

msg me on discord. same username as github

@FlorianMichael
Copy link

Anvil GUI likely would not work due to a client limitation where we cannot influence the outcome. Seeing that this issue is still there due to the geyser bug with the Via workaround, i'll reopen this

I think Anvil GUI would work, I don't know the nbt number for it though whereas the viaversion devs do. But i'm going through random gui menu's now until i could find that one.

I can build you a ViaVersion jar with the anvil as gui if you want

I am building the different ones on a fork. msg me on discord. same username as github

I have sent you the Jar

@FlorianMichael
Copy link

Anvil GUI likely would not work due to a client limitation where we cannot influence the outcome. Seeing that this issue is still there due to the geyser bug with the Via workaround, i'll reopen this

I have now gone through all the GUIs that are available in the Java Edition and Bedrock Edition, and could not find one that works equally well on both editions and which would not be a downgrade compared to the current fix in ViaVersion.

@Camotoy
Copy link
Member

Camotoy commented Jun 14, 2023

Thanks for looking into it.

Perhaps the best solution on the client end would be to just... show the original smithing table, since as far as I can tell Bedrock doesn't actually have that removed.

I'll talk with the Via guys about an idea I have.

@raphaelfasilva
Copy link

raphaelfasilva commented Jun 16, 2023

Geyser Team,

Have prevision to solve these problem, because players of my server everytime ask me about it.

Thank You Raphael Silva

@roggy666
Copy link

How long will it take to fix this problem? And will it ever ?

@gre3x
Copy link

gre3x commented Jun 22, 2023

Any updates on this? My players also complaining about this

@Konicai
Copy link
Member

Konicai commented Jun 23, 2023

If we provide a fix or workaround for this it'll be declared here. There is no ETA - asking for an update just clutters this issue

@Hay127
Copy link

Hay127 commented Jul 5, 2023

Nah Guys to solve this problem I use Smithing Table Fix 1.0, you can download it via bukkit

@MrBsng
Copy link

MrBsng commented Jul 7, 2023

Nah Guys to solve this problem I use Smithing Table Fix 1.0, you can download it via bukkit

It was good for the time being, but unlike this closed source plugin, I have developed a much more seamless fix in my 3rd party open source Bukkit plugin found here. https://github.com/TBYT/BedrockParity/releases

@frogglen
Copy link

frogglen commented Jul 7, 2023

Nah Guys to solve this problem I use Smithing Table Fix 1.0, you can download it via bukkit

It was good for the time being, but unlike this user-experience-intrusive closed source plugin, I have developed a much more seamless fix in my 3rd party open source Spigot plugin found here. https://github.com/TBYT/GeyserParity/releases

Does this plugin replace the GeyserHacks plugin?
or are they separate plugins?

@Camotoy
Copy link
Member

Camotoy commented Jul 7, 2023

They are separate plugins.

@Chenyu550
Copy link

Chenyu550 commented Jul 21, 2023

Haven't fixed it yet? It has been more than one month.

@Hay127

This comment was marked as off-topic.

@Konicai
Copy link
Member

Konicai commented Jul 21, 2023

No, this issue hasn't been fixed. Please don't simply comment asking if its been fixing - we'll provide updates or close the issue if it is ever fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Confirmed Bug The bug reported is confirmed and able to be replicated.
Projects
None yet
Development

Successfully merging a pull request may close this issue.