Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sweeping Edge Book doesn't work in the anvil. #3661

Closed
Tyviebrock opened this issue Apr 3, 2023 · 7 comments
Closed

Sweeping Edge Book doesn't work in the anvil. #3661

Tyviebrock opened this issue Apr 3, 2023 · 7 comments
Labels
Duplicate The issue is a duplicate of another.

Comments

@Tyviebrock
Copy link

Tyviebrock commented Apr 3, 2023

Describe the bug

Sweeping edge enchanted books don't work in the second slot of an anvil.

To Reproduce

1.) Get sweeping edge from trading or enchanting a book
2.) Attempt to enchanted your sword with the enchanted book in an anvil

Expected behaviour

It'll enchant your sword with no issues.

Screenshots / Videos

No response

Server Version and Plugins

Paper version git-Paper-477 (MC: 1.19.4) (Implementing API version 1.19.4-R0.1-SNAPSHOT) (Git: 5c78e77)

Geyser Dump

No response

Geyser Version

2.1.0-SNAPSHOT (git-master-0f99abc)

Minecraft: Bedrock Edition Device/Version

1.19.73 Nintendo Switch

Additional Context

Additionally if you combine sweeping edge with a different enchantment, it needs to be in the first slot.

However if try to combine this combined book with a sword it'll either remove the sweeping edge or just not work if you already have the secondary enchant.

@Tyviebrock Tyviebrock changed the title Sweeping Edge doesn't work in the anvil. Sweeping Edge Book doesn't work in the anvil. Apr 3, 2023
@MrBsng
Copy link

MrBsng commented Apr 3, 2023

I have a workaround papermc plugin here just for this, use the latest release https://github.com/TBYT/BedrockParity/releases
Also this issue should stay open as this is not in Geyser yet.

@onebeastchris
Copy link
Member

Unfortunately, due to certain bedrock limitations, it won't be easily possible to 'enable' this behavior in Geyser.
Your best bet is probably using a workaround plugin, TBYT's one for example, or try adding the book together with other enchantments.

Bedrock, for some reason, doesn't allow custom enchantments in enchantment tables or anvils - therefore, full 1:1 java enchanting isn't really possible.
Same reason as for why infinity+mending bows can't be made on bedrock even if the server allows it via a plugin - the client partly controls the anvil, it's not fully server side.

@onebeastchris
Copy link
Member

However, there shouldn't be a case where sweeping edge gets removed outright (unless you e.g. put the book on a pair of boots or similar) - does the enchantment appear when relogging/closing and reopening your inventory?

@Tyviebrock
Copy link
Author

However, there shouldn't be a case where sweeping edge gets removed outright (unless you e.g. put the book on a pair of boots or similar) - does the enchantment appear when relogging/closing and reopening your inventory?

So after putting the sword in the anvil with the sweeping edge enchant, sweeping edge wasn't being displayed in the hover over tooltip on the resulting part. But after combining it the name was displaying. (I didn't do this part until now).

@onebeastchris
Copy link
Member

Okay, that's the behavior that is expected.
The only reason Sweeping edge shows up at all is because it's shown in the item lore - when combining it, the preview doesn't show sweeping edge, as the preview apparently doesn't have it yet.
But it should - as it did here - show up "again" when combined :)

So yay, that works ~
The only real way we could try and fix this is if Bedrock were to add the enchantment, or if Bedrock would allow anvil behavior modifications

@Tyviebrock
Copy link
Author

I did also notice that enchanted books with just sweeping edge lose their yellow name.

@Jens-Co Jens-Co added the Missing Implementation This has yet to be implemented. label Apr 25, 2023
@onebeastchris
Copy link
Member

#2972 closing this in favor of the other post - this boils down to Bedrock having no support for custom enchantments, and us being unable to modify anvil behavior which is controlled client-side.
Thanks anyway for reporting!

@onebeastchris onebeastchris closed this as not planned Won't fix, can't repro, duplicate, stale Jun 11, 2023
@onebeastchris onebeastchris added Duplicate The issue is a duplicate of another. and removed Missing Implementation This has yet to be implemented. labels Jun 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Duplicate The issue is a duplicate of another.
Projects
None yet
Development

No branches or pull requests

4 participants