Properly remove observer upon deconstruction (#8) (#17)

kanat · kanat · commit 143fdd448a5d · 2024-03-25T13:20:24.000-07:00
(cherry picked from commit 829f351) (cherry picked from commit 01ed14c)
diff --git a/pc/video_rtp_receiver.cc b/pc/video_rtp_receiver.cc
@@ -50,6 +50,8 @@ VideoRtpReceiver::VideoRtpReceiver(
 VideoRtpReceiver::~VideoRtpReceiver() {
   RTC_DCHECK_RUN_ON(&signaling_thread_checker_);
   RTC_DCHECK(!media_channel_);
+
+  track_->UnregisterObserver(this);
 }
 
 std::vector<std::string> VideoRtpReceiver::stream_ids() const {

Original file line number	Diff line number	Diff line change
`@@ -50,6 +50,8 @@ VideoRtpReceiver::VideoRtpReceiver(`
`50`	`50`	`VideoRtpReceiver::~VideoRtpReceiver() {`
`51`	`51`	`RTC_DCHECK_RUN_ON(&signaling_thread_checker_);`
`52`	`52`	`RTC_DCHECK(!media_channel_);`
	`53`	`+`
	`54`	`+ track_->UnregisterObserver(this);`
`53`	`55`	`}`
`54`	`56`
`55`	`57`	`std::vector<std::string> VideoRtpReceiver::stream_ids() const {`