Add a way to intercept the audio samples before processing #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielNovak
force-pushed
the
add_audio_intercept
branch
from
74c589a to
fce4c0e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR adds a new
setAudioRecordDataCallback(...)function into theJavaAudioDeviceModule.Builder. This can be used to intercept the rawByteBufferwith the capture audio sample before it's sent to the native WebRTC part. The client application can then use it to apply simple audio filters to the audio recorded by the device.There is no impact or breaking change on existing clients - the code will not do anything unless a callback is set.