chore: upgrade to React v19 #2615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2615 +/- ##
==========================================
- Coverage 81.09% 81.00% -0.09%
==========================================
Files 449 449
Lines 9489 9489
Branches 2231 2231
==========================================
- Hits 7695 7687 -8
- Misses 1684 1686 +2
- Partials 110 116 +6 ☔ View full report in Codecov by Sentry. |
MartinCupela
commented
Jan 22, 2025
| import '@testing-library/jest-dom'; | ||
| import renderer from 'react-test-renderer'; |
There was a problem hiding this comment.
react-test-renderer has been deprecated. Therefore many snapshots had to be changed.
|
Size Change: +7.94 kB (+0.67%) Total Size: 1.2 MB
ℹ️ View Unchanged
|
MartinCupela
commented
Jan 22, 2025
| @@ -1,4 +1,4 @@ | |||
| import { act, renderHook } from '@testing-library/react-hooks'; | |||
| import { act, renderHook } from '@testing-library/react'; | |||
There was a problem hiding this comment.
@testing-library/react-hooks does not seem to be continued - it has not been updated to be compatible with React v19.
oliverlaz
approved these changes
Jan 27, 2025
MartinCupela
force-pushed
the
chore/react-19-upgrade
branch
from
caaeffe to
20e4c90
Compare
# Conflicts: # package.json
|
🎉 This PR is included in version 12.10.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
In order to be able to run stream-chat-react with React v19 you need to allow for our dependency react-markdown to install its own version of React types. Add the following section to your package.json: "resolutions": {
"react-markdown/@types/react": "^18.0.0"
}After that do not forget to remove and re-install |
I'm trying this fix with pnpm with no luck, has anyone else had success? "pnpm": {
"overrides": {
"react-markdown>@types/react": "^18.0.0"
}
}, |
|
@davidchalifoux I'm running into the same issue. Were you able to find a fix? |
Yes I ended up manually patching version 8.0.7 of I can't give you exact instructions, but the diff looks like this (specifically lines 24-28): |
|
That seemed to work for me. Thanks @davidchalifoux! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested locally with app running on
Fixes React-253