fix: issue with loading app settings when the connectUser is not called on app (#2654)

* fix: issue with loading app settings when the connectUser is not called on app

* fix: add comments

* fix: add comments

Author: khushal87

package/src/components/Chat/hooks/__tests__/useAppSettings.test.tsx

@@ -18,7 +18,6 @@ describe('useAppSettings', () => {
               auto_translation_enabled: true,
             }),
           ),
-          userID: 'some-user-id',
         } as unknown as StreamChat,
         isOnline,
         false,

package/src/components/Chat/hooks/useAppSettings.ts

@@ -18,12 +18,32 @@ export const useAppSettings = <
   const isMounted = useIsMountedRef();
 
   useEffect(() => {
-    async function enforeAppSettings() {
-      if (!client.userID) return;
+    /**
+     * Fetches app settings from the backend when offline support is disabled.
+     */
+    const enforceAppSettingsWithoutOfflineSupport = async () => {
+      try {
+        const appSettings = await client.getAppSettings();
+        if (isMounted.current) {
+          setAppSettings(appSettings);
+        }
+      } catch (error: unknown) {
+        if (error instanceof Error) {
+          console.error(`An error occurred while getting app settings: ${error}`);
+        }
+      }
+    };
 
-      if (enableOfflineSupport && !initialisedDatabase) return;
+    /**
+     * Fetches app settings from the local database when offline support is enabled if internet is off else fetches from the backend.
+     * Note: We need to set the app settings from the local database when offline as the client will not have the app settings in memory. For this we store it for the `client.userID`.
+     *
+     * TODO: Remove client.userID usage for offline support case.
+     */
+    const enforceAppSettingsWithOfflineSupport = async () => {
+      if (!client.userID) return;
 
-      if (!isOnline && enableOfflineSupport) {
+      if (!isOnline) {
         const appSettings = dbApi.getAppSettings({ currentUserId: client.userID });
         setAppSettings(appSettings);
         return;
@@ -33,17 +53,24 @@ export const useAppSettings = <
         const appSettings = await client.getAppSettings();
         if (isMounted.current) {
           setAppSettings(appSettings);
-          enableOfflineSupport &&
-            dbApi.upsertAppSettings({
-              appSettings,
-              currentUserId: client.userID as string,
-            });
+          dbApi.upsertAppSettings({
+            appSettings,
+            currentUserId: client.userID as string,
+          });
         }
       } catch (error: unknown) {
         if (error instanceof Error) {
           console.error(`An error occurred while getting app settings: ${error}`);
         }
       }
+    };
+
+    async function enforeAppSettings() {
+      if (enableOfflineSupport) {
+        await enforceAppSettingsWithOfflineSupport();
+      } else {
+        await enforceAppSettingsWithoutOfflineSupport();
+      }
     }
 
     enforeAppSettings();