Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AND-253] Message stateless component factories #5593

Merged
merged 9 commits into from
Jan 28, 2025
Merged

[AND-253] Message stateless component factories #5593

merged 9 commits into from
Jan 28, 2025

Conversation

andremion
Copy link
Collaborator

@andremion andremion commented Jan 28, 2025 •
edited
Loading

🎯 Goal

  • Create message stateless component factories.
  • Refactor to have a single component factory object.

@andremion andremion added enhancement New feature or request compose Jetpack Compose labels Jan 28, 2025
@andremion andremion changed the title [AND-253] Messages stateless component factories [AND-253] Message stateless component factories Jan 28, 2025
@andremion andremion force-pushed the AND-253-messages-stateless-components branch from b44fb85 to 38bbf4f Compare January 28, 2025 10:54
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 28, 2025 •
edited
Loading

SDK Size Comparison 📏

SDK Before After Difference Status
stream-chat-android-client 3.17 MB 3.17 MB 0.00 MB 🟢
stream-chat-android-offline 3.38 MB 3.38 MB 0.00 MB 🟢
stream-chat-android-ui-components 7.86 MB 7.86 MB 0.00 MB 🟢
stream-chat-android-compose 8.72 MB 8.73 MB 0.01 MB 🟢

@andremion andremion marked this pull request as ready for review January 28, 2025 10:59
@andremion andremion requested a review from a team as a code owner January 28, 2025 10:59
@andremion andremion enabled auto-merge (squash) January 28, 2025 14:17
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
42.5% Coverage on New Code (required ≥ 80%)
7.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@andremion andremion merged commit 70a40af into develop Jan 28, 2025
11 of 12 checks passed
@andremion andremion deleted the AND-253-messages-stateless-components branch January 28, 2025 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VelikovPetar VelikovPetar VelikovPetar left review comments

@aleksandar-apostolov aleksandar-apostolov aleksandar-apostolov approved these changes

Assignees
No one assigned
Labels
compose Jetpack Compose enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andremion @aleksandar-apostolov @VelikovPetar