Skip to content

Commit 267dfb4

Browse files
authored
Merge pull request #85 from phadej/prepare-for-2.1.3
Update CHANGELOG for 2.1.3
2 parents b2ff991 + 814a86e commit 267dfb4

File tree

8 files changed

+19
-27
lines changed

8 files changed

+19
-27
lines changed

Diff for: CHANGELOG.md

+4-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,10 @@
11
2.1.3
22
-----
33

4-
* Add UUID instances (see [#81](https://github.com/GetShopTV/swagger2/pull/81)).
4+
* Add [`UUID`](http://hackage.haskell.org/package/uuid-types/docs/Data-UUID-Types.html#t:UUID) instances (see [#81](https://github.com/GetShopTV/swagger2/pull/81)).
5+
* Add [`TypeError`](https://hackage.haskell.org/package/base-4.9.0.0/docs/GHC-TypeLits.html#g:4) `ToSchema` and `ToParamSchema ByteString` instances (see [#78](https://github.com/GetShopTV/swagger2/pull/78))
6+
* Improve documentation for generic sum type instance derivation (see [#75](https://github.com/GetShopTV/swagger2/pull/75))
7+
* Compile warning free (see [#82](https://github.com/GetShopTV/swagger2/pull/82))
58

69
2.1.2.1
710
-------

Diff for: src/Data/Swagger/Internal/ParamSchema.hs

+5-3
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,8 @@
1515
#if __GLASGOW_HASKELL__ >= 800
1616
-- Generic a is redundant in ToParamSchema a default imple
1717
{-# OPTIONS_GHC -Wno-redundant-constraints #-}
18+
-- For TypeErrors
19+
{-# OPTIONS_GHC -Wno-unticked-promoted-constructors #-}
1820
#endif
1921
#include "overlapping-compat.h"
2022
module Data.Swagger.Internal.ParamSchema where
@@ -207,9 +209,9 @@ instance ToParamSchema TL.Text where
207209
#else
208210
type family ToParamSchemaByteStringError bs where
209211
ToParamSchemaByteStringError bs = TypeError
210-
( Text "Impossible to have an instance " :<>: ShowType (ToParamSchema bs) :<>: Text "."
211-
:$$: Text "Please, use a newtype wrapper around " :<>: ShowType bs :<>: Text " instead."
212-
:$$: Text "Consider using byteParamSchema or binaryParamSchema templates." )
212+
( 'Text "Impossible to have an instance " :<>: ShowType (ToParamSchema bs) :<>: Text "."
213+
:$$: 'Text "Please, use a newtype wrapper around " :<>: ShowType bs :<>: Text " instead."
214+
:$$: 'Text "Consider using byteParamSchema or binaryParamSchema templates." )
213215

214216
instance ToParamSchemaByteStringError BS.ByteString => ToParamSchema BS.ByteString where toParamSchema = error "impossible"
215217
instance ToParamSchemaByteStringError BSL.ByteString => ToParamSchema BSL.ByteString where toParamSchema = error "impossible"

Diff for: src/Data/Swagger/Internal/Schema.hs

+2
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,8 @@
1717
#if __GLASGOW_HASKELL__ >= 800
1818
-- Few generics related redundant constraints
1919
{-# OPTIONS_GHC -Wno-redundant-constraints #-}
20+
-- For TypeErrors
21+
{-# OPTIONS_GHC -Wno-unticked-promoted-constructors #-}
2022
#endif
2123
#include "overlapping-compat.h"
2224
module Data.Swagger.Internal.Schema where

Diff for: stack-lts-2.yaml

+5
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,14 @@ extra-deps:
99
- generics-sop-0.2.1.0
1010
- insert-ordered-containers-0.1.0.1
1111
- primitive-0.6.1.0
12+
- QuickCheck-2.8.2
1213
- tagged-0.8.4
1314
- unordered-containers-0.2.7.0
1415
resolver: lts-2.22
1516
flags:
1617
aeson:
1718
old-locale: true
19+
QuickCheck:
20+
base3: false
21+
base4: true
22+
base4point8: false

Diff for: swagger2.cabal

+1-1
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ test-suite spec
7777
, insert-ordered-containers
7878
, HUnit
7979
, mtl
80-
, QuickCheck
80+
, QuickCheck >=2.8.2
8181
, swagger2
8282
, text
8383
, time

Diff for: test/Data/Swagger/ParamSchemaSpec.hs

+1-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ import SpecCommon
1818
import Test.Hspec
1919

2020
checkToParamSchema :: ToParamSchema a => Proxy a -> Value -> Spec
21-
checkToParamSchema proxy js = (toParamSchema proxy :: ParamSchema (SwaggerKindNormal Param)) <=> js
21+
checkToParamSchema proxy js = (toParamSchema proxy :: ParamSchema ('SwaggerKindNormal Param)) <=> js
2222

2323
spec :: Spec
2424
spec = do

Diff for: test/Data/Swagger/Schema/ValidationSpec.hs

+1-19
Original file line numberDiff line numberDiff line change
@@ -1,36 +1,30 @@
11
{-# LANGUAGE CPP #-}
22
{-# LANGUAGE DeriveGeneric #-}
33
{-# LANGUAGE PackageImports #-}
4+
{-# OPTIONS_GHC -fno-warn-orphans #-}
45
module Data.Swagger.Schema.ValidationSpec where
56

67
import Control.Applicative
78
import Data.Aeson
89
import Data.Aeson.Types
910
import Data.Int
1011
import Data.IntMap (IntMap)
11-
import qualified Data.IntMap as IntMap
12-
import Data.IntSet (IntSet)
1312
import Data.Hashable (Hashable)
1413
import "unordered-containers" Data.HashSet (HashSet)
1514
import qualified "unordered-containers" Data.HashSet as HashSet
1615
import Data.HashMap.Strict (HashMap)
1716
import qualified Data.HashMap.Strict as HashMap
1817
import Data.Map (Map)
19-
import qualified Data.Map as Map
2018
import Data.Proxy
2119
import Data.Time
2220
import qualified Data.Text as T
2321
import qualified Data.Text.Lazy as TL
2422
import Data.Set (Set)
25-
import qualified Data.Set as Set
2623
import Data.Word
2724
import GHC.Generics
2825

2926
import Data.Swagger
30-
import Data.Swagger.Declare
31-
import Data.Swagger.Schema.Validation
3227

33-
import SpecCommon
3428
import Test.Hspec
3529
import Test.Hspec.QuickCheck
3630
import Test.QuickCheck
@@ -168,18 +162,6 @@ instance Arbitrary Light where
168162

169163
-- Arbitrary instances for common types
170164

171-
#if MIN_VERSION_QuickCheck(2,8,2)
172-
#else
173-
instance (Ord k, Arbitrary k, Arbitrary v) => Arbitrary (Map k v) where
174-
arbitrary = Map.fromList <$> arbitrary
175-
176-
instance Arbitrary a => Arbitrary (IntMap a) where
177-
arbitrary = IntMap.fromList <$> arbitrary
178-
179-
instance (Ord a, Arbitrary a) => Arbitrary (Set a) where
180-
arbitrary = Set.fromList <$> arbitrary
181-
#endif
182-
183165
instance (Eq k, Hashable k, Arbitrary k, Arbitrary v) => Arbitrary (HashMap k v) where
184166
arbitrary = HashMap.fromList <$> arbitrary
185167

Diff for: test/Data/Swagger/SchemaSpec.hs

-2
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,9 @@ import Control.Lens ((^.))
1111
import Data.Aeson
1212
import Data.Aeson.QQ
1313
import Data.Char
14-
import qualified Data.HashMap.Strict as HashMap
1514
import qualified Data.HashMap.Strict.InsOrd as InsOrdHashMap
1615
import Data.Proxy
1716
import Data.Set (Set)
18-
import qualified Data.Set as Set
1917
import qualified Data.Text as Text
2018
import GHC.Generics
2119

0 commit comments

Comments
 (0)