Make the forum usable with JavaScript disabled #1325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bonus: the modification brought to the user profile nav tabs makes it possible to open settings tabs in new browser tabs, which was not possible with pure Bootstrap tabs. |
|
Additional JavaScript tweak: show a confirm box when the user tries to leave a page while editing a post form. This prevents from accidentally closing a page where we're actually typing a post. |
|
Nice work. |
Studio384
pushed a commit
that referenced
this pull request
Jul 1, 2015
Make the forum usable with JavaScript disabled
34 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Luna relies on Bootstrap for some actions, making it hard to use when JavaScript is disabled. The profile tabs and user menu will not work, for instance, preventing users from editing their profile or even log out.
Details: I added a WordPress-like duet of classes,
hide-if-jsandhide-if-no-js; ano-jsclass is set tobodyand turned tojsright after loading. Elements with ahide-if-no-jswill be hidden ifbodyhas ano-jsclass set, while elements with ahide-if-jswill be hidden ifbodyhas ajsclass set. This way we can easily chose what should or should not be displayed on a JS enabled/disabled context.