Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

o_smilies - To delete or not to delete #1268

Closed
Quy opened this issue Apr 21, 2015 · 2 comments
Closed

o_smilies - To delete or not to delete #1268

Quy opened this issue Apr 21, 2015 · 2 comments
Assignees
Milestone

Comments

@Quy
Copy link
Contributor

Quy commented Apr 21, 2015

db_update.php deletes it but install.php inserts it.

db_update.php

        // Since 0.9.4229: Remove obsolete o_smilies permission from config table
        if (array_key_exists('o_smilies', $luna_config))
            $db->query('DELETE FROM '.$db->prefix.'config WHERE conf_name = \'o_smilies\'') or error('Unable to remove config value \'o_smilies\'', __FILE__, __LINE__, $db->error());

install.php

            'o_smilies'                 => 1,
@Studio384 Studio384 added this to the Luna 1.0.2 milestone Apr 21, 2015
@Studio384 Studio384 self-assigned this Apr 21, 2015
@Studio384
Copy link
Member

Thanks for reporting.

Studio384 pushed a commit that referenced this issue Apr 21, 2015
@Studio384 Studio384 mentioned this issue Apr 21, 2015
9 tasks
@Quy
Copy link
Contributor Author

Quy commented Apr 21, 2015

Sorry, I should have mentioned the use of it in the themes:

<?php if ($luna_config['o_smilies'] == '1' || $luna_config['o_smilies_sig'] == '1' || $luna_config['o_signatures'] == '1' || $luna_config['o_avatars'] == '1' || $luna_config['p_message_img_tag'] == '1'): ?>
<?php if ($luna_config['o_smilies'] == '1' || $luna_config['o_smilies_sig'] == '1'): ?>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants