Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Icon issue in topic view navbar #1106

Closed
Studio384 opened this issue Mar 16, 2015 · 5 comments
Closed

Icon issue in topic view navbar #1106

Studio384 opened this issue Mar 16, 2015 · 5 comments
Assignees
@Studio384
Labels
bug
Milestone
Luna 1.0 Aero

Comments

@Studio384
Copy link
Member

So we have this weird issue with the navbars icons in the forum view and post view for Inbox. If anyone has an idea on how to fix this, or why this happens in the first place, be my guest, I've tried to search everywhere, and couldn't find it...

You can see the bug here in the navbar: http://forum.getluna.org/viewtopic.php?id=714 (you have to be logged in to see the issue).

@Quy, perhaps you can help me further?
@Studio384 Studio384 added the bug label Mar 16, 2015
@Studio384 Studio384 added this to the Luna 1.0 Aero milestone Mar 16, 2015
@Studio384 Studio384 mentioned this issue Mar 16, 2015
Closed
@Quy
Copy link
Contributor

Quy commented Mar 16, 2015

I see the search icon display issue but I am not seeing what you are referring to. Please attach screenshot.

@Studio384
Copy link
Member Author

correctmain
Above, this is how the navbar is supposed to look, and the way it looks on prety much all of our pages.

wrong
Howerver, this is how the navbar looks in the topic view and when posting or editing a post/PM. Both the search icon and icons in the user area are not centered. For some reason, the Font Awesome icons seem to lose their hight.

withoutstylewrong
The issue doesn't seem to be in the themes of Luna, as it also appears, as seen above, when only the Bootstrap and Font Awesome styles are in affect. And the issue is still not there in other pages:
withoutstylecorrect

Do you have any idea why this happens?

@Quy
Copy link
Contributor

Quy commented Mar 17, 2015

It is because of the JavaScript code not being in the <head></head> tags.

<script type="text/javascript">
/* <![CDATA[ */
function process_form(the_form) {
    var required_fields = {
        "req_message": "Message",
        "req_subject": "Subject"
    };
    if (document.all || document.getElementById) {
        for (var i = 0; i < the_form.length; ++i) {
            var elem = the_form.elements[i];
            if (elem.name && required_fields[elem.name] && !elem.value && elem.type && (/^(?:text(?:area)?|password|file)$/i.test(elem.type))) {
                alert('"' + required_fields[elem.name] + '" is a required field in this form.');
                elem.focus();
                return false;
            }
        }
    }
    return true;
}
/* ]]> */
</script>
<!DOCTYPE html>
<html>
    <head>

@Studio384
Copy link
Member Author

Might explain why this only happens on pages with textareas... :) Anyway, thanks, I'll look into it.

@Studio384 Studio384 self-assigned this Mar 17, 2015
Studio384 pushed a commit that referenced this issue Mar 17, 2015
#1106 Load javascript in head, not outside html
ceb4a82
@Studio384
Copy link
Member Author

Thanks for the help. Can't believe I didn't notice that. It's fixed. Finally.

@Studio384 Studio384 mentioned this issue Mar 17, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Studio384 Studio384

Labels
bug
Projects
None yet
Milestone
Luna 1.0 Aero
Development

No branches or pull requests
2 participants
@Quy @Studio384