-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests #17
Comments
I can help with that |
Thanks for helping with this issue. I think it'll also teach me a lot about the testing environment as I am a beginner in this. 😅 |
@GermaVinsmoke can i open a new issue to refactor the folder organization ? |
Yeah |
@GermaVinsmoke i think you need to do some changes in your code to turn easier to test your components. For example you can avoid magic numbers using constants, like in It's a good practice to use Another point is that you're calculating a lot of bussiness logic inside 'handleChange', it's not wrong, but you could do that in another function for example. You can open new PR's if you want, or just ignore all these considetations. |
Add tests to test App.jsx and Bar.jsx
The text was updated successfully, but these errors were encountered: