Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Lamp nodes that are referencing non-existing library_lights #143

Merged
merged 1 commit into from
Dec 8, 2022

Conversation

petrikvladimir
Copy link

The library_lights were removed in commit
However, the references to the library remain, and they block trimesh library from loading the meshes as shown here. This PR removes the nodes associated with lights.

@hrp2-14
Copy link

hrp2-14 commented Nov 29, 2022

Hi ! This project doesn't usually accept pull requests on the main branch.
If this wasn't intentionnal, you can change the base branch of this PR to devel
(No need to close it for that). Best, a bot.

@petrikvladimir petrikvladimir changed the base branch from master to devel November 29, 2022 14:27
Copy link
Member

@nim65s nim65s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

Copy link
Collaborator

@cmastalli cmastalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @petrikvladimir !

@wxmerkt
Copy link
Contributor

wxmerkt commented Dec 8, 2022

Is this good to merge? Some parsers (Three.js) fail without the fixes in this PR

@nim65s nim65s merged commit f19b2db into Gepetto:devel Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants