Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Readme.MD - Default value for timeout in seconds should be 180 not 3 #32

Closed
AjaySrin7 opened this issue Mar 9, 2022 · 0 comments · May be fixed by #33
Closed

Readme.MD - Default value for timeout in seconds should be 180 not 3 #32

AjaySrin7 opened this issue Mar 9, 2022 · 0 comments · May be fixed by #33
Assignees
@rubenplaza

Comments

@AjaySrin7
Copy link

The 'timeout' property in the options object has a description of "The length of time the wrapper will wait for a response from the server (in seconds)" but the default value specified as 3. Someone probably meant 3 minutes. Better to change it to 180 to match the base unit (seconds)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rubenplaza rubenplaza

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update timeout time to seconds instead of minutes rubenplaza/mg-api-js
3 participants
@beefo @AjaySrin7 @rubenplaza