Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update handlebars to 4.3.0 or later #4953

Closed
t-book opened this issue Sep 26, 2019 · 1 comment · Fixed by #4989
Closed

Update handlebars to 4.3.0 or later #4953

t-book opened this issue Sep 26, 2019 · 1 comment · Fixed by #4989
Labels
security Pull requests that address a security vulnerability
Milestone
2.10.1

Comments

@t-book
Copy link
Contributor

t-book commented Sep 26, 2019

Handlebars is getting outdated let's update it.
@t-book t-book added the security Pull requests that address a security vulnerability label Sep 26, 2019
@t-book t-book changed the title Update hanldebars to 4.3.0 or later Update handlebars to 4.3.0 or later Sep 26, 2019
@t-book
Copy link
Contributor Author

t-book commented Sep 29, 2019

Dear @afabiani I'm just trying to tidy the FE-Dependencies. It looks handlebars has been introduced with this commit: 1bcf487#diff-93259bcb570c92f4bb499a216ba8f235

what wonders is I cannot find it in latest version of bower.json.

https://github.com/GeoNode/geonode/blob/17e061b8a6e800c7bba67de9936a5a62a6d0e810/geonode/static/bower.json

Do you remember any component which might use it?

@afabiani afabiani added this to the 2.10.1 milestone Oct 3, 2019
@t-book t-book mentioned this issue Oct 6, 2019
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
security Pull requests that address a security vulnerability
Projects
None yet
Milestone
2.10.1
Development

Successfully merging a pull request may close this issue.

[Fixes: 4988] Rework static build process t-book/geonode
2 participants
@afabiani @t-book