Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VEditorKit: Define default caret rect using with style.minHeight #52

Merged
merged 1 commit into from
Feb 11, 2019

Conversation

GeekTree0101
Copy link
Owner

Why need this change?:

  • Empty Text View Caret size is too small & unmatched with default typing paragraph lineheight

Change made & impact:

  • Setup style minimum height

Test Scope:

  • minimumTextContainerTextLineHeight() should be return expected height

Vertified snapshots (optional)

@GeekTree0101 GeekTree0101 added the bug Something isn't working label Feb 11, 2019
@codecov-io
Copy link

Codecov Report

Merging #52 into master will increase coverage by 0.03%.
The diff coverage is 80%.

@@            Coverage Diff             @@
##           master      #52      +/-   ##
==========================================
+ Coverage   67.01%   67.04%   +0.03%     
==========================================
  Files          25       25              
  Lines        1737     1742       +5     
==========================================
+ Hits         1164     1168       +4     
- Misses        573      574       +1

Copy link
Collaborator

@OhKanghoon OhKanghoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@OhKanghoon OhKanghoon merged commit ccb7139 into master Feb 11, 2019
@OhKanghoon OhKanghoon deleted the feature/VEditorKit-Define-Default-Caret-Rect branch February 11, 2019 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants