Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Fix cursor visible scrolling bug #48

Merged
merged 1 commit into from
Feb 7, 2019

Conversation

GeekTree0101
Copy link
Owner

Why need this change?:

  • Sometimes scrollToCursor: calculate invalid visibleRect with table content size height

Change made & impact:

  • Get expected y-offset between y-offset of visibleRect and tableNode content height

Test Scope:

  • UI Test Skip

Vertified snapshots (optional)

@GeekTree0101 GeekTree0101 added the bug Something isn't working label Feb 1, 2019
@codecov-io
Copy link

Codecov Report

Merging #48 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #48   +/-   ##
=======================================
  Coverage   67.01%   67.01%           
=======================================
  Files          25       25           
  Lines        1737     1737           
=======================================
  Hits         1164     1164           
  Misses        573      573

Copy link
Collaborator

@OhKanghoon OhKanghoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OhKanghoon OhKanghoon merged commit 1feec72 into master Feb 7, 2019
@OhKanghoon OhKanghoon deleted the bug/VEditorKit-Cursor-visible-scrolling-bug-fix branch February 7, 2019 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants