Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjustment of qualified target destination strings #201

Open
sinewavey opened this issue Jun 18, 2024 · 2 comments
Open

Adjustment of qualified target destination strings #201

sinewavey opened this issue Jun 18, 2024 · 2 comments

Comments

@sinewavey
Copy link

sinewavey commented Jun 18, 2024

https://github.com/Garux/netradiant-custom/blob/ac7b4d3cd408916534187304cfbbd41471350027/plugins/entity/namekeys.h#L130C4-L130C90

ConnectEntities( Entity* e1, Entity* e2, int index ) : m_e1( e1 ), m_e2( e2 ), m_targetkey( index == 1? "killtarget" : "target" ){

class TargetKeys : public Entity::Observer

So it seems that entities drawing target lines as per your changelog + what I could dig up seems to accept "target", "targetN" (where N is an int), and "killtarget" (ound that out by reading HL FGD)

Is it possible to adjust this at all or expose a blank "force acceptable" check here for custom games? Or perhaps another prefix?

Use case: in Godot one thing someone may need to do is reparent an entity to another entity. It's a bit awkward to hook into the same strict target name system.

Again - minor details. Not really impacting usage too much. I've just been setting up my game's entities a bit more formally.
Thanks, and as always, really appreciate the work ya do.

image

@Garux
Copy link
Owner

Garux commented Jun 19, 2024

#80
requires performance evaluation and cfg idea is to use existing xml ent def type system

@sinewavey
Copy link
Author

Cool. This should be okay to close as it's a duplicate then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants