Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PokeWorld incompatibility with "Vanilla Factions Expanded" #30

Open
Ltserb opened this issue Oct 31, 2022 · 3 comments
Open

PokeWorld incompatibility with "Vanilla Factions Expanded" #30

Ltserb opened this issue Oct 31, 2022 · 3 comments

Comments

@Ltserb
Copy link

Ltserb commented Oct 31, 2022

When caravans attempt to spawn, 2 errors are thrown and no caravan spawns

Any, all, or none of the DLCs active
Version 1.4.3531
Harmony Lib 2.2.2.0, Mod 1.5.0.0

Start game with PokeWorld loaded and any combination of Vanilla Factions Expanded; Medieval, Settlers, or Vikings (other Factions do not produce this error)
Load a game, start a new game, or start a DevQuickTest
Wait for, or attempt to spawn using "Do Incident (Map)\TraderCaravanArrival", a trader caravan
The Trader Caravan fails to spawn and the following errors are placed in the log

https://gist.github.com/Ltserb/4bd541eac17e81277d0136d8e4d02fa4

Reading comments and discussions, this appears to have been occurring since at least the beginning of the year with no official bug report submitted

@Ltserb
Copy link
Author

Ltserb commented Nov 11, 2022

Workaround

Disable "allowNPCPokemonPack" in options

@Ltserb
Copy link
Author

Ltserb commented Nov 11, 2022

Issue lies in "PawnGroupKindWorker_Trader_GenerateCarriers_Patch.cs"

Line 21 if (!PokeWorldSettings.OkforPokemon() || PokeWorldSettings.allowNPCPokemonPack == false)
Line 25 Else statement does not assign "kinds.RandomElementByWeight" which is requested by Line 33 "for (int j = 0; j < num; j++)" line 40 Else statement

@patrin88
Copy link

Workaround

Disable "allowNPCPokemonPack" in options

Thanks for finding a workaround I was wondering why no caravans were coming to visit me. I'm having the same issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants