Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDL2 still linking dxerr.lib #2163

Closed
chaigler opened this issue Jan 24, 2018 · 2 comments
Closed

SDL2 still linking dxerr.lib #2163

chaigler opened this issue Jan 24, 2018 · 2 comments
Labels
Defect

Comments

@chaigler
Copy link
Contributor

chaigler commented Jan 24, 2018 •
edited
Loading

SDL2 is still linking dxerr.lib on Windows. dxerr.lib was deprecated years ago and isn't included in any of the recent Windows SDKs so it breaks compilation unless the DX SDK is installed (gross). SDL2 doesn't actually use this lib so I'm not sure why it links it at all.

Here's some more info: davidsiaw/SDL2#1

Easy fix, just update the SDL2 make file to remove the dependency.
@chaigler chaigler mentioned this issue Jan 24, 2018
Merged
@Areloch Areloch added the Defect label Jan 26, 2018
@Areloch
Copy link
Contributor

Areloch commented Jan 31, 2018

Fixed per PR.

@Areloch Areloch closed this as completed Jan 31, 2018
@chaigler
Copy link
Contributor Author

chaigler commented Jul 4, 2018

@Areloch - Looks like this creeped in again in one of the recent PRs. We're back to linking against dxerr.

@chaigler chaigler mentioned this issue Jul 4, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Areloch @chaigler