-
Notifications
You must be signed in to change notification settings - Fork 78
Remove heapster package (#2574). #2576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Make sure to also remove the following:
|
104003d to
24b5f5a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This also definitely needs a changelog entry...
...which should also specifically call out that the signature of write_coq_cryptol_primitives_for_sawcore has changed.
39e7e38 to
6f9ebb3
Compare
|
It looks like heapster/examples/bc-annot/foo.saw came back by accident. Also, test_type_errors/err053 uses the HeapsterEnv type as a deprecated type to test on, so it will blow up when that's removed. There isn't any other deprecated type at present so we might need to either create a dummy one (which is kind of annoying) or disable the test (which is also kind of annoying). |
Oops, it looks like I made a mistake with my rebase. I'll give it another try. |
2c4ab09 to
dd0df02
Compare
dd0df02 to
da4b723
Compare
Stuff happens :-) |
Also document the changed type for write_coq_cryptol_primitives_for_sawcore.
Also introduce new deprecated type "__DEPRECATED__" so that we have a type to use with expected-error tests.
sauclovian-g
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last kibitz, then I think you can merge it :-)
CHANGES.md
Outdated
|
|
||
| * The deprecated Heapster, MRSolver, and Monadify features have been | ||
| removed. | ||
| The following SAW commands are no longer available: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might also mention the RefnSet type here since it's not immediately obvious to passersby that it's linked to this stuff. (HeapsterEnv pretty obviously is, so mentioning it probably doesn't matter one way or the other.)
No description provided.