Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid use of git:// URLs in submodules #1620

Closed
RyanGlScott opened this issue Mar 17, 2022 · 3 comments · Fixed by #2141
Closed

Avoid use of git:// URLs in submodules #1620

RyanGlScott opened this issue Mar 17, 2022 · 3 comments · Fixed by #2141
Assignees
Labels
PR: submodule bump Pull requests that include a submodule bump tech debt Issues that document or involve technical debt tooling: CI Issues involving CI/CD scripts or processes
Milestone

Comments

@RyanGlScott
Copy link
Contributor

GitHub recently removed support for git:// URLs. Unfortunately, this causes problems for SAW, at least one submodule makes use of a git:// URL. See this failing CI job for an example:

Submodule 'blst' (https://github.com/supranational/blst) registered for path 'blst'
Submodule 'cryptol-specs' (git://github.com/GaloisInc/cryptol-specs) registered for path 'cryptol-specs'
Cloning into '/workdir/blst'...
Cloning into '/workdir/cryptol-specs'...
fatal: remote error: 
  The unauthenticated git protocol on port 9418 is no longer supported.
Please see https://github.blog/2021-09-01-improving-git-protocol-security-github/ for more information.
fatal: clone of 'git://github.com/GaloisInc/cryptol-specs' into submodule path '/workdir/cryptol-specs' failed

This arises from this line in the blst-verification repo. It's possible that there are others, too, since heapster.saw resorts to this trick:

# Necessary to deal with SSH URLs in some submodules
RUN git config --global url."https://github.com/".insteadOf [email protected]: && \
git config --global url."https://".insteadOf git://

Now that git:// is officially no longer supported, we should:

  1. Patch all affected submodules upstream to remove their use of git:// URLs,
  2. Update the commits in saw-script's Dockerfiles accordingly, and
  3. Remove any uses of git config --global url."https://".insteadOf git:// in the Dockerfiles to ensure that everything works as expected.
@RyanGlScott RyanGlScott added tech debt Issues that document or involve technical debt PR: submodule bump Pull requests that include a submodule bump tooling: CI Issues involving CI/CD scripts or processes labels Mar 17, 2022
@sauclovian-g
Copy link
Contributor

There are no such URLs left these days.

@sauclovian-g
Copy link
Contributor

That was a little optimistic; there's still an insteadOf. Also, there's a stray reference in one of macaw's cabal files that probably doesn't affect us but should get fixed in macaw.

@sauclovian-g
Copy link
Contributor

The macaw leftover is now GaloisInc/macaw#449. I don't think we need to wait to pull it into saw-script before closing this issue, unless something unexpected happens.

@sauclovian-g sauclovian-g self-assigned this Nov 2, 2024
@sauclovian-g sauclovian-g added this to the 2024T3 milestone Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: submodule bump Pull requests that include a submodule bump tech debt Issues that document or involve technical debt tooling: CI Issues involving CI/CD scripts or processes
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants