Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python names for LLVM values/types inconsistent #1164

Closed
pnwamk opened this issue Mar 26, 2021 · 2 comments
Closed

Python names for LLVM values/types inconsistent #1164

pnwamk opened this issue Mar 26, 2021 · 2 comments
Labels
subsystem: saw-remote-api Issues related to the SAW server and its RPC bindings

Comments

@pnwamk
Copy link
Contributor

pnwamk commented Mar 26, 2021

It looks like the constructor names for LLVM values and types in the python interface don't really have a consistency to them =\ IMO we should address this soon and then stick to whatever naming pattern we prefer.

Options:

  1. Use a consistent suffix for each, e.g., NAME_val and NAME_ty (pros: simple, predictable; cons: a few additional characters here and there)
  2. Use no suffixes, but places values and types in modules which can be imported with whatever prefix is desired (pros: flexible, users decide prefix to import with (if any); cons: val.NAME and ty.NAME might look funny, if no prefix is present from the import it may be difficult to determine meaning from code).
@pnwamk pnwamk added the subsystem: saw-remote-api Issues related to the SAW server and its RPC bindings label Mar 26, 2021
@RyanGlScott
Copy link
Contributor

I think (1) is closest to my ideal, although I don't think we need to use the suffixes for every definition. For instance, I think global_var is fine as it is, and global_var_val would just be unnecessarily redundant.

@pnwamk
Copy link
Contributor Author

pnwamk commented Apr 2, 2021

Fixed by #1168

@pnwamk pnwamk closed this as completed Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
subsystem: saw-remote-api Issues related to the SAW server and its RPC bindings
Projects
None yet
Development

No branches or pull requests

2 participants