From 3f1f035176c8dffb9e8a83dd3b6666f6f50d2297 Mon Sep 17 00:00:00 2001 From: Sam Breese Date: Mon, 1 Aug 2022 14:45:32 -0400 Subject: [PATCH 1/4] Temporarily disable saw-remote-api tests on MacOS --- .github/workflows/ci.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 38bbf191e1..6b62aee889 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -293,8 +293,9 @@ jobs: include: - test: saw-remote-api/scripts/run_rpc_tests.sh os: ubuntu-18.04 - - test: saw-remote-api/scripts/run_rpc_tests.sh - os: macos-12 + # TODO: These tests are disabled pending resolution of issue #1699 + # - test: saw-remote-api/scripts/run_rpc_tests.sh + # os: macos-12 - test: saw-remote-api/scripts/check_docs.sh os: ubuntu-18.04 steps: From 9181119691e68918b130a82d0f81cf0e9f27173c Mon Sep 17 00:00:00 2001 From: Sam Breese Date: Mon, 1 Aug 2022 15:57:31 -0400 Subject: [PATCH 2/4] Disable slightly less zealously --- .github/workflows/ci.yml | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 6b62aee889..baebe09410 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -294,8 +294,12 @@ jobs: - test: saw-remote-api/scripts/run_rpc_tests.sh os: ubuntu-18.04 # TODO: These tests are disabled pending resolution of issue #1699 - # - test: saw-remote-api/scripts/run_rpc_tests.sh - # os: macos-12 + - test: | + cd saw-remote-api/ + poetry update + poetry install + poetry run mypy saw_client/ + os: macos-12 - test: saw-remote-api/scripts/check_docs.sh os: ubuntu-18.04 steps: From 43904673a32431bff98b4d16cb5e221485741ee2 Mon Sep 17 00:00:00 2001 From: Sam Breese Date: Mon, 1 Aug 2022 17:16:07 -0400 Subject: [PATCH 3/4] Fix path, update test names --- .github/workflows/ci.yml | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index baebe09410..f955112dae 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -291,16 +291,19 @@ jobs: fail-fast: false matrix: include: - - test: saw-remote-api/scripts/run_rpc_tests.sh + - name: Install and test + test: saw-remote-api/scripts/run_rpc_tests.sh os: ubuntu-18.04 # TODO: These tests are disabled pending resolution of issue #1699 - - test: | - cd saw-remote-api/ + - name: Install on MacOS + test: | + cd saw-remote-api/python/ poetry update poetry install poetry run mypy saw_client/ os: macos-12 - - test: saw-remote-api/scripts/check_docs.sh + - name: Check docs + test: saw-remote-api/scripts/check_docs.sh os: ubuntu-18.04 steps: - uses: actions/checkout@v2 @@ -325,7 +328,7 @@ jobs: with: poetry-version: 1.1.5 - - name: ${{ matrix.test }} + - name: ${{ matrix.name }} shell: bash run: | chmod +x dist/bin/* From 78e30a5a3ee9aa386ec44ff5f9f2f35f400f9b51 Mon Sep 17 00:00:00 2001 From: Sam Breese Date: Tue, 2 Aug 2022 13:13:07 -0400 Subject: [PATCH 4/4] Change comment to be more descriptive --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index f955112dae..e60eb90754 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -294,7 +294,7 @@ jobs: - name: Install and test test: saw-remote-api/scripts/run_rpc_tests.sh os: ubuntu-18.04 - # TODO: These tests are disabled pending resolution of issue #1699 + # TODO: saw-remote-api unit tests are disabled pending a fix for #1699 - name: Install on MacOS test: | cd saw-remote-api/python/