Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finish migration of cryptol-remote-api #917

Closed
4 of 10 tasks
atomb opened this issue Sep 30, 2020 · 2 comments
Closed
4 of 10 tasks

Finish migration of cryptol-remote-api #917

atomb opened this issue Sep 30, 2020 · 2 comments
Assignees
@atomb
Labels
build system Related to Cryptol's build system

Comments

@atomb
Copy link
Contributor

atomb commented Sep 30, 2020 •
edited
Loading

The recently-added argo submodule is a temporary artifact of migrating the cryptol-remote-api package from the argo repository to the cryptol repository. The ultimate goal is to make cryptol and cryptol-remote-api development more closely coupled so that it's easier to make changes to keep them in sync and to build them together if desired. The following is a tentative plan to complete that migration. Comments welcome!

  • Move the cryptol-remote-api Cabal package from the argo repository to the cryptol repository. It would remain a separate package, and would not add any dependencies to the cryptol package, but would live alongside it for ease of maintenance.
  • Add an argo submodule to the saw-script repository, as well.
  • Move the saw-remote-api package from the argo repository to the saw-script repository.
  • Remove all submodules from the argo repository.
  • Refactor the cryptol-remote-api test suite to avoid the need for Python.
  • Refactor the saw-remote-api test suite to avoid the need for Python.
  • Publish the argo package to Hackage, as it rarely changes now.
  • Decide where to store and how to package the Python client library.
  • Remove the argo submodule from the cryptol repository.
  • Remove the argo submodule from the saw-script repository.
@atomb atomb added this to the 2.10.0 milestone Sep 30, 2020
@robdockins
Copy link
Contributor

This seems relatively reasonable to me, aside from the big question mark about what we're doing with the Python client libraries.

@atomb atomb mentioned this issue Sep 30, 2020
Merged
@robdockins robdockins added the build system Related to Cryptol's build system label Sep 30, 2020
@atomb atomb self-assigned this Oct 7, 2020
@atomb atomb removed this from the 2.10.0 milestone Nov 13, 2020
@robdockins robdockins mentioned this issue Nov 24, 2020
Closed
@atomb
Copy link
Contributor Author

atomb commented Jan 28, 2021

The remaining check boxes on this issue have been migrated to issues in the argo repository (or are made unnecessary by those issues):

GaloisInc/argo#145
GaloisInc/argo#146
GaloisInc/argo#147

@atomb atomb closed this as completed Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atomb atomb

Labels
build system Related to Cryptol's build system
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@atomb @robdockins