Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sum-types: What should the private keyword do for constructors? #1610

Closed
RyanGlScott opened this issue Jan 19, 2024 · 1 comment
Closed

sum-types: What should the private keyword do for constructors? #1610

RyanGlScott opened this issue Jan 19, 2024 · 1 comment
Labels
design needed We need to specify precisely what we want enums Issues related to enums

Comments

@RyanGlScott
Copy link
Contributor

On the sum-types branch (#1602), it is possible to annotate a constructor as private. Currently, this does nothing, and private constructors are exported anyway. It's unclear if we actually want the ability to mark enum constructors as private however—what does it mean to only export some of an enum's constructors?

We should come to a conclusion about what design we want and either (1) implement the feature, or (2) remove it.

@RyanGlScott RyanGlScott added design needed We need to specify precisely what we want enums Issues related to enums labels Jan 19, 2024
@RyanGlScott
Copy link
Contributor Author

We opted to remove this for now in 8abf33f. We can always add this back later if someone requests it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design needed We need to specify precisely what we want enums Issues related to enums
Projects
None yet
Development

No branches or pull requests

1 participant