Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for foreign functions in top-level functor #1566

Closed
qsctr opened this issue Aug 23, 2023 · 0 comments · Fixed by #1568
Closed

Check for foreign functions in top-level functor #1566

qsctr opened this issue Aug 23, 2023 · 0 comments · Fixed by #1568
Assignees
@qsctr
Labels
bug Something not working correctly FFI Foreign function interface parameterized modules Related to Cryptol's parameterized modules

Comments

@qsctr
Copy link
Contributor

qsctr commented Aug 23, 2023

Currently we have a check to disallow foreign functions in submodule functors but not top-level ones. We should disallow them in top-level functors too.
@qsctr qsctr added bug Something not working correctly parameterized modules Related to Cryptol's parameterized modules FFI Foreign function interface labels Aug 23, 2023
@qsctr qsctr self-assigned this Aug 23, 2023
@qsctr qsctr mentioned this issue Aug 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qsctr qsctr

Labels
bug Something not working correctly FFI Foreign function interface parameterized modules Related to Cryptol's parameterized modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes for handling foreign functions GaloisInc/cryptol
1 participant
@qsctr