Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish up support for Newtypes #1033

Closed
robdockins opened this issue Jan 13, 2021 · 2 comments
Closed

Finish up support for Newtypes #1033

robdockins opened this issue Jan 13, 2021 · 2 comments
Assignees
Labels
priority For issues that should be solved sooner remote-api Related to Cryptol's remote API

Comments

@robdockins
Copy link
Contributor

The cryptol remote API still needs some work to be able to handle some unique issues that arise from newtypes (basically, the generative nature of newtype declarations). See:

TVNewtype _u _ts _tfs -> liftIO $ throwIO (invalidType (tValTy ty))

In addition, I think we should consider if newtypes should be allowed as property arguments. I'm starting to be inclined to say they should not be allowed, as this might break internal invariants. However, it makes them considerably less convenient, without something like #1028 to make it easier to program generation code for newtype values.

@robdockins robdockins added design needed We need to specify precisely what we want remote-api Related to Cryptol's remote API and removed design needed We need to specify precisely what we want labels Jan 13, 2021
@robdockins
Copy link
Contributor Author

CF #1037.

This ticket should really just be for finishing the remote-api work.

@atomb atomb added the priority For issues that should be solved sooner label May 20, 2021
@pnwamk
Copy link
Contributor

pnwamk commented Jun 17, 2021

Initial support for newtypes and other complex values has been added to the cryptol server: #1200

@pnwamk pnwamk closed this as completed Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority For issues that should be solved sooner remote-api Related to Cryptol's remote API
Projects
None yet
Development

No branches or pull requests

3 participants