e2e test for best practice content pages #2074
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
ccostino
reviewed
Nov 15, 2024
There was a problem hiding this comment.
Thank you, @heyitsmebev! I had just one quick question to double check on, everything else looks good to me.
| page.wait_for_load_state("domcontentloaded") | ||
| check_axe_report(page) | ||
|
|
||
| response = page.request.get(f"{E2E_TEST_URI}/test/feature-flags") |
There was a problem hiding this comment.
Just double checking my understanding: this is just getting the response of the feature-flags URI, not actually going to the page, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the end2end epic, this issue is to create testing for the new Best Practice content pages side nav
In my implementation, I'm using an endpoint to retrieve feature flags in E2E tests because Playwright runs in a browser environment and can't access Flask's server-side configuration (current_app.config). This endpoint allows Playwright to check feature flags dynamically, enabling conditional tests based on the feature's state.