Build: Refactor makefiles #71
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a base Makefile that should be common to GRTeclyn examples (once there is more than one) and eventually the tests too. There is also a new amrex-objects target in the root makefile which should fix #68 as it is a dependency of the examples targets although this does rely on the examples keeping the same default configuration (i.e. USE_MPI = TRUE, COMP = gnu). I have added a base name to the BinaryBH example.
Also switch to building fcompare with MPI so that we don't have to build AMReX source files twice.
mirenradia
added
the
github_actions
|
@julianakwan, would you be able to check this resolves the CI issues you were finding on your matter/scalar field branches? |
Yeah, I'll test it out as a part of my usual suite of checks for PRs :) |
|
I merged the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a base Makefile that should be common to GRTeclyn examples (once there is more than one) and eventually the tests too.
There is also a new
amrex-objectstarget in the root makefile which should fix #68 as it is a dependency of the examples targets although this does rely on the examples keeping the same default configuration (i.e.USE_MPI = TRUE,COMP = gnu).I have added a base name to the BinaryBH example.