Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simulation sometimes fails to abort when NanCheck finds a NaN with >1 OpenMP thread. #238

Open
KAClough opened this issue Jul 10, 2023 · 0 comments · May be fixed by #239
Open

Simulation sometimes fails to abort when NanCheck finds a NaN with >1 OpenMP thread. #238

KAClough opened this issue Jul 10, 2023 · 0 comments · May be fixed by #239
Assignees
Labels
bug Something isn't working

Comments

@KAClough
Copy link
Member

Sometimes slurm (on some clusters) fails to exit when there is a nan - this means the program ends but does not exit, which is annoying and wastes resources.

The problem is with OpenMP - it works if you run with only one thread. The solution seems to be that the master thread needs to call the exit, but then we need to make sure that it is not only the master thread that can find nan to exit - we want it to exit for nan on any thread, and also we still want the thread that finds the nan to write out the data of where it is.

@KAClough KAClough added the bug Something isn't working label Jul 10, 2023
@mirenradia mirenradia changed the title Slurm doesn't exit in Nancheck with openMP Simulation sometimes fails to abort when NanCheck finds a NaN with >1 OpenMP thread. Jul 10, 2023
@KAClough KAClough linked a pull request Jul 10, 2023 that will close this issue
@mirenradia mirenradia linked a pull request Jul 10, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants