Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is HLSL support turned off if ANVIL_LINK_WITH_GLSLANG flag is set? #145

Open
Silverlan opened this issue Apr 3, 2019 · 1 comment
Open
Assignees
Labels

Comments

@Silverlan
Copy link
Contributor

Silverlan commented Apr 3, 2019

It looks like the ENABLE_HLSL flag is automatically turned off in CMake whenever the ANVIL_LINK_WITH_GLSLANG flag is set. Why is that? I don't see why they would be mutually exclusive, since the hlsl-api is included in the glslang library.

If there is a reason for that, I think the description for the ANVIL_LINK_WITH_GLSLANG flag should reflect that, since it's not obvious at all (imo).

@DominikWitczakAMD
Copy link
Contributor

The reason behind the setter is that we do not use this functionality (yet) internally, so I don't know if Anvil would need to expose additional functions to provide HLSL support to end users.

Also, we care about compilation times and removing the unnecessary pieces of the library from the build process is one of the ways with which we try to achieve this.

What if we added a CMake option which would allow HLSL parts to be included if your app needs this? Would that work ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants