From 23beaac111a565fa6b9a4f2988acad9568af2b7b Mon Sep 17 00:00:00 2001 From: ozkanonur Date: Fri, 24 Mar 2023 18:14:07 +0300 Subject: [PATCH 1/6] use `ubuntu-18.04` for dev and release builds Signed-off-by: ozkanonur --- .github/workflows/dev-build.yml | 2 +- .github/workflows/release-build.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/dev-build.yml b/.github/workflows/dev-build.yml index 7bbb5f5f92..f40a9ff6e7 100644 --- a/.github/workflows/dev-build.yml +++ b/.github/workflows/dev-build.yml @@ -14,7 +14,7 @@ env: jobs: linux-x86-64: timeout-minutes: 30 - runs-on: ubuntu-latest + runs-on: ubuntu-18.04 steps: - uses: actions/checkout@v3 - name: Install toolchain diff --git a/.github/workflows/release-build.yml b/.github/workflows/release-build.yml index 21820340a1..decc670fae 100644 --- a/.github/workflows/release-build.yml +++ b/.github/workflows/release-build.yml @@ -11,7 +11,7 @@ env: jobs: linux-x86-64: timeout-minutes: 60 - runs-on: ubuntu-latest + runs-on: ubuntu-18.04 steps: - uses: actions/checkout@v3 - name: Install toolchain From 0249d00e641d5246642f6ad24961e1a13f8d2e39 Mon Sep 17 00:00:00 2001 From: ozkanonur Date: Fri, 24 Mar 2023 15:33:48 +0000 Subject: [PATCH 2/6] always cancel previous `in-progress` pipelines when new commit pushed Signed-off-by: ozkanonur --- .github/workflows/dev-build.yml | 4 ++++ .github/workflows/fmt-and-lint.yml | 4 ++++ .github/workflows/release-build.yml | 4 ++++ .github/workflows/test.yml | 4 ++++ .github/workflows/virustotal_scan.yml | 4 ++++ 5 files changed, 20 insertions(+) diff --git a/.github/workflows/dev-build.yml b/.github/workflows/dev-build.yml index f40a9ff6e7..b799d1a9b3 100644 --- a/.github/workflows/dev-build.yml +++ b/.github/workflows/dev-build.yml @@ -7,6 +7,10 @@ on: branches: - dev +concurrency: + group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }} + cancel-in-progress: true + env: BRANCH_NAME: ${{ github.head_ref || github.ref_name }} MANUAL_MM_VERSION: true diff --git a/.github/workflows/fmt-and-lint.yml b/.github/workflows/fmt-and-lint.yml index 6ee8a2c1a2..b9c5c92701 100644 --- a/.github/workflows/fmt-and-lint.yml +++ b/.github/workflows/fmt-and-lint.yml @@ -9,6 +9,10 @@ on: - main - dev +concurrency: + group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }} + cancel-in-progress: true + jobs: fmt-and-lint: timeout-minutes: 45 diff --git a/.github/workflows/release-build.yml b/.github/workflows/release-build.yml index decc670fae..2556fd47e3 100644 --- a/.github/workflows/release-build.yml +++ b/.github/workflows/release-build.yml @@ -4,6 +4,10 @@ on: branches: - main +concurrency: + group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }} + cancel-in-progress: true + env: BRANCH_NAME: ${{ github.head_ref || github.ref_name }} MANUAL_MM_VERSION: true diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index ae9b84fe07..5cd82b5311 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -9,6 +9,10 @@ on: - main - dev +concurrency: + group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }} + cancel-in-progress: true + env: FROM_SHARED_RUNNER: true diff --git a/.github/workflows/virustotal_scan.yml b/.github/workflows/virustotal_scan.yml index 551990ddc0..b292e47050 100644 --- a/.github/workflows/virustotal_scan.yml +++ b/.github/workflows/virustotal_scan.yml @@ -4,6 +4,10 @@ on: release: types: [created, edited, released, published] +concurrency: + group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }} + cancel-in-progress: true + jobs: virustotal: runs-on: ubuntu-latest From 86daf564a5d55aedb1c70d1de3c570a8b1aab557 Mon Sep 17 00:00:00 2001 From: ozkanonur Date: Fri, 24 Mar 2023 18:51:10 +0300 Subject: [PATCH 3/6] switch from `ubuntu-latest` to `ubuntu-18.04` for all builds Signed-off-by: ozkanonur --- .github/workflows/dev-build.yml | 8 ++++---- .github/workflows/release-build.yml | 6 +++--- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/.github/workflows/dev-build.yml b/.github/workflows/dev-build.yml index b799d1a9b3..d401096109 100644 --- a/.github/workflows/dev-build.yml +++ b/.github/workflows/dev-build.yml @@ -197,7 +197,7 @@ jobs: wasm: timeout-minutes: 30 - runs-on: ubuntu-latest + runs-on: ubuntu-18.04 steps: - uses: actions/checkout@v3 - name: Install toolchain @@ -285,7 +285,7 @@ jobs: android-aarch64: timeout-minutes: 30 - runs-on: ubuntu-latest + runs-on: ubuntu-18.04 steps: - uses: actions/checkout@v3 - name: Install toolchain @@ -333,7 +333,7 @@ jobs: android-armv7: timeout-minutes: 30 - runs-on: ubuntu-latest + runs-on: ubuntu-18.04 steps: - uses: actions/checkout@v3 - name: Install toolchain @@ -384,7 +384,7 @@ jobs: if: github.event_name != 'pull_request' needs: linux-x86-64 timeout-minutes: 15 - runs-on: ubuntu-latest + runs-on: ubuntu-18.04 steps: - uses: actions/checkout@v2 diff --git a/.github/workflows/release-build.yml b/.github/workflows/release-build.yml index 2556fd47e3..11dcfd2f38 100644 --- a/.github/workflows/release-build.yml +++ b/.github/workflows/release-build.yml @@ -192,7 +192,7 @@ jobs: wasm: timeout-minutes: 60 - runs-on: ubuntu-latest + runs-on: ubuntu-18.04 steps: - uses: actions/checkout@v3 - name: Install toolchain @@ -280,7 +280,7 @@ jobs: android-aarch64: timeout-minutes: 60 - runs-on: ubuntu-latest + runs-on: ubuntu-18.04 steps: - uses: actions/checkout@v3 - name: Install toolchain @@ -328,7 +328,7 @@ jobs: android-armv7: timeout-minutes: 60 - runs-on: ubuntu-latest + runs-on: ubuntu-18.04 steps: - uses: actions/checkout@v3 - name: Install toolchain From 8a5d2700531525950c1b0df98ff38989e12dcfb6 Mon Sep 17 00:00:00 2001 From: ozkanonur Date: Fri, 24 Mar 2023 18:58:23 +0300 Subject: [PATCH 4/6] turn off share generics nightly feature Signed-off-by: ozkanonur --- .cargo/config | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.cargo/config b/.cargo/config index 564b1fb152..98802b0c00 100644 --- a/.cargo/config +++ b/.cargo/config @@ -1,8 +1,8 @@ [env] JEMALLOC_SYS_WITH_MALLOC_CONF = "percpu_arena:percpu,oversize_threshold:0,background_thread:true,metadata_thp:auto,dirty_decay_ms:5000,muzzy_decay_ms:5000" -[target.'cfg(all())'] -rustflags = [ "-Zshare-generics=y" ] +# [target.'cfg(all())'] +# rustflags = [ "-Zshare-generics=y" ] # # Install lld using package manager # [target.x86_64-unknown-linux-gnu] From 43b8d71996e2766653743dc593950b42469346a5 Mon Sep 17 00:00:00 2001 From: ozkanonur Date: Fri, 24 Mar 2023 19:11:59 +0300 Subject: [PATCH 5/6] set JEMALLOC environments in CI Signed-off-by: ozkanonur --- .cargo/config | 6 +++--- .github/workflows/dev-build.yml | 1 + .github/workflows/release-build.yml | 1 + 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/.cargo/config b/.cargo/config index 98802b0c00..c81c668c82 100644 --- a/.cargo/config +++ b/.cargo/config @@ -1,8 +1,8 @@ [env] -JEMALLOC_SYS_WITH_MALLOC_CONF = "percpu_arena:percpu,oversize_threshold:0,background_thread:true,metadata_thp:auto,dirty_decay_ms:5000,muzzy_decay_ms:5000" +JEMALLOC_SYS_WITH_MALLOC_CONF = "background_thread:true,narenas:1,tcache:false,dirty_decay_ms:0,muzzy_decay_ms:0,metadata_thp:auto" -# [target.'cfg(all())'] -# rustflags = [ "-Zshare-generics=y" ] +[target.'cfg(all())'] +rustflags = [ "-Zshare-generics=y" ] # # Install lld using package manager # [target.x86_64-unknown-linux-gnu] diff --git a/.github/workflows/dev-build.yml b/.github/workflows/dev-build.yml index d401096109..900048e6ae 100644 --- a/.github/workflows/dev-build.yml +++ b/.github/workflows/dev-build.yml @@ -14,6 +14,7 @@ concurrency: env: BRANCH_NAME: ${{ github.head_ref || github.ref_name }} MANUAL_MM_VERSION: true + JEMALLOC_SYS_WITH_MALLOC_CONF: 'background_thread:true,narenas:1,tcache:false,dirty_decay_ms:0,muzzy_decay_ms:0,metadata_thp:auto' jobs: linux-x86-64: diff --git a/.github/workflows/release-build.yml b/.github/workflows/release-build.yml index 11dcfd2f38..9cf009f810 100644 --- a/.github/workflows/release-build.yml +++ b/.github/workflows/release-build.yml @@ -11,6 +11,7 @@ concurrency: env: BRANCH_NAME: ${{ github.head_ref || github.ref_name }} MANUAL_MM_VERSION: true + JEMALLOC_SYS_WITH_MALLOC_CONF: 'background_thread:true,narenas:1,tcache:false,dirty_decay_ms:0,muzzy_decay_ms:0,metadata_thp:auto' jobs: linux-x86-64: From cacc7060a286cc099234951c41a672b8f29a4af8 Mon Sep 17 00:00:00 2001 From: ozkanonur Date: Fri, 24 Mar 2023 19:43:16 +0300 Subject: [PATCH 6/6] rollback jemalloc entry from changelog Signed-off-by: ozkanonur --- CHANGELOG.md | 1 - 1 file changed, 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 08907103bd..94ef07eb01 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -31,7 +31,6 @@ - CI/CD migrated from Azure to Github runners [#1699](https://github.com/KomodoPlatform/atomicDEX-API/pull/1699) - CI tests are much stabilized [#1699](https://github.com/KomodoPlatform/atomicDEX-API/pull/1699) - Integration and unit tests are seperated on CI stack [#1699](https://github.com/KomodoPlatform/atomicDEX-API/pull/1699) -- Jemalloc configuration updated for optimization purposes [#1699](https://github.com/KomodoPlatform/atomicDEX-API/pull/1699) - Codebase is updated in linting rules at wasm and test stack [#1699](https://github.com/KomodoPlatform/atomicDEX-API/pull/1699) - `crossbeam` bumped to `0.8` from `0.7` [#1699](https://github.com/KomodoPlatform/atomicDEX-API/pull/1699) - Un-used/Unstable parts of mm2 excluded from build outputs which avoids mm2 runtime from potential UB [#1699](https://github.com/KomodoPlatform/atomicDEX-API/pull/1699)