Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renaming batch_dim #118

Open
josephdviviano opened this issue Aug 2, 2023 · 0 comments
Open

Renaming batch_dim #118

josephdviviano opened this issue Aug 2, 2023 · 0 comments
Assignees
@josephdviviano

Comments

@josephdviviano
Copy link
Collaborator

Right now batch_dim actually has two, specific dimensions:

would it make more sense for the batch_dim[0] to be named batch_dim and batch_dim[1] to be named trajectory_dim or something (since I assume that’s what these two batch dimensions will always be used for?)

Definitely, that’s always the case for trajectories. The first dimension is the maximum length of the trajectories. The second is the number of trajectories. How could we do the renaming ?

We need to explore how to implement this in the code, which would make everything much clearer to the user.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@josephdviviano josephdviviano

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@josephdviviano