12월 백엔드 포스트 #258
Merged
12월 백엔드 포스트 #258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iju1633
reviewed
Jan 2, 2023
|
|
||
| ### HandlerMethodArgumentResolver | ||
|
|
||
| 가장 핵심이 되는 인터페이스는 `HandlerMethodArgumentResolver` 이다. 해당 인터페이스는 두가지 method의 구현을 필요로 한다. |
There was a problem hiding this comment.
[Nit] 두가지 -> 2 가지로 수정하시면 가독성이 더욱 좋을 것 같습니다.
iju1633
reviewed
Jan 2, 2023
| class UserArgumentResolverConfiguration( | ||
| private val userResolver: UserResolver, | ||
| ) : WebMvcConfigurer { | ||
| override fun addArgumentResolvers(resolvers:MutableList<HandlerMethodArgumentResolver>) { |
There was a problem hiding this comment.
fun과 addArgument 사이에 불필요한 공백이 있어 수정 부탁드립니다.
iju1633
requested changes
Jan 2, 2023
iju1633
left a comment
iju1633
left a comment
There was a problem hiding this comment.
글을 읽으며 객체 파라미터를 주입받는 방법 중, 잘 몰랐던 handler나 resolver에 대해서도 어떻게 작동하는 지 알 수 있었네요! 좋은 글 감사합니다 :)
seunghb320
previously approved these changes
Jan 23, 2023
seunghb320
left a comment
seunghb320
left a comment
There was a problem hiding this comment.
앞서 말씀해주신 부분 외에는 저는 수정 관련해서는 딱히 요청할게 없습니다. 좋은 글 정말 감사드립니다:)
iju1633
approved these changes
Jan 29, 2023
iju1633
added
💯 최종 완료
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.