Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HttpOptions.TimeoutInSeconds not working for values higher than 100s #721

Open
FlorianHockmann opened this issue Jan 3, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@FlorianHockmann
Copy link
Member

If I'm not mistaken, then the HttpOptions.TimeoutInSeconds are not working as expected right now because they are only used to create a policy which will let the HTTP request timeout after the specified timeout.
The HttpClient used for that request however also has a timeout which defaults to 100s. If the configured timeout is higher than that, then the request will timeout after 100 seconds and the configured timeout used in the policy will never be used.

I am not sure why we use this policy at all if the HttpClient already has a timeout. We should probably remove the timeout policy completely and instead just configure the timeout used for HttpClient.

We could also use this opportunity to refactor TimeoutInSeconds into a TimeSpan Timeout which would be more consistent with other such settings in .NET.

@FlorianHockmann FlorianHockmann added the bug Something isn't working label Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant