Fix various experiment header issues #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jescalada
changed the title
|
@fabiovincenzi It seems I accidentally removed one of your recent changes to the These were your original changes: Any ideas on how to reconciliate the changes? 🤔 |
vinayan3
pushed a commit
to vinayan3/fasttrackml-ui-aim
that referenced
this pull request
Aug 28, 2024
* Fix rerender issue with no selected params * Fix metrics error bug * Fix select form popper styling * Update createAppModel.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for G-Research/fasttrackml#1021 and G-Research/fasttrackml#1022.
#1021
This fixed an issue with the console erroring out on empty metrics query:
Now we get the desired "No Results" page, and no query is done on backend.
#1022
The issue was that when I wrote the
ExperimentSelectionHeader, I did not add theselectedExperimentNamesas a state within theMetricsBar. The state was working correctly under normal circumstances because the view was getting refreshed anyways when querying. Empty queries are not sent to the server to begin with, therefore no refresh was happening.Explanation: Added extra state to
MetricsBarand set it on the handler function:onSelectExperimentNamesChange()changes the model and toggles the experiment internallysetSelectedExperiments()updates the view to reflect the recent changesNote: #1021 was also affected by these changes and has been tested as well.
Extra
I fixed a small misalignment in the
SelectFormPoppermetrics/params.