Skip to content

Unblock the CI for enterprise version #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Jul 25, 2023
Merged

Unblock the CI for enterprise version #227

merged 20 commits into from
Jul 25, 2023

Conversation

@marcin-krystianc
Copy link
Contributor

@marcin-krystianc marcin-krystianc commented Jul 24, 2023 •
edited
Loading

This PR:

  1. Fixes version parsing by using a class that properly understands semantic versioning (e.g. version 1.6.10+ent)
  2. We run Enterprise tests on all branches.
  3. We don't have the license environment variable set yet, but it turns out that older versions of Consul can be run anyway.

@marcin-krystianc marcin-krystianc changed the title Log the version to debug enterprise version failures ("Input string was not in a correct format") Unblock the CI for enterprise version Jul 24, 2023
@marcin-krystianc
Copy link
Contributor Author

marcin-krystianc commented Jul 25, 2023

This is ready for review.

mfkl
mfkl approved these changes Jul 25, 2023
View reviewed changes
Copy link
Contributor

@mfkl mfkl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have the license environment variable set yet

I guess this would be for a follow up PR then (and whether we want to enable the secret for PR builds).

@marcin-krystianc marcin-krystianc merged commit c10d637 into master Jul 25, 2023
@marcin-krystianc marcin-krystianc deleted the dev-marcink-20230724-version-logging branch July 25, 2023 12:50
This was referenced Oct 30, 2025
Closed
Closed
Closed
@dependabot dependabot bot mentioned this pull request Oct 30, 2025
Open
@dependabot dependabot bot mentioned this pull request Nov 8, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jgiannuzzi jgiannuzzi Awaiting requested review from jgiannuzzi

1 more reviewer

@mfkl mfkl mfkl approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@marcin-krystianc @mfkl