Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ES Modules are in Safari TP #5897

Closed
surma opened this issue May 10, 2021 · 10 comments
Closed

ES Modules are in Safari TP #5897

surma opened this issue May 10, 2021 · 10 comments

Comments

@surma
Copy link

surma commented May 10, 2021

I tried to find the raw data in the JSON for mdn-api_worker_worker_ecmascript_modules, but wasn’t successful.

The table currently reads “unknown”, but support was added in Safari TP 122 (announcement).

Where/How can I fix that?

@Schweinepriester
Copy link
Contributor

Schweinepriester commented May 10, 2021

TL;DR: https://github.com/mdn/browser-compat-data/blob/main/api/Worker.json#L138 :)


Hi @surma! 🤩

That feature is coming from https://github.com/mdn/browser-compat-data (BCD).

The fastest way to get to the data from caniuse is to check the tab Feedback of a given feature, so in this case:

the support data for this feature.

=> Starting at this line: https://github.com/mdn/browser-compat-data/blob/main/api/Worker.json#L138

Sadly BCD doesn't track Safari TP (yet?): mdn/browser-compat-data#4840 (comment) :/

However!
Per https://webkit.org/blog/11648/new-webkit-features-in-safari-14-1/#:~:text=availability

Changes in this release of Safari were included in the following Safari Technology Preview releases: 110111112113114115116117118119120121122.

support should also be in Safari 14.1 (including iOS 14.5) 🎉
So you could change the data to show support starting with those versions.

Do you have a test at hand? If you want me to I could check Safari 14.1 and iOS 14.5 :)

@meliixo

This comment has been minimized.

@surma
Copy link
Author

surma commented May 11, 2021

@Schweinepriester Thanks for the guidance!

I don’t have a test at hand, but I did check WPT, where Safari TP is passing the tests but Safari 14.1 is not

@Schweinepriester
Copy link
Contributor

Bummer! Looking at the changesets and issues of

  • Added support for modules in Workers and Worklets (r273203)
  • Added support for modules in Service Workers (r273224)

I couldn't find a flag or discussion to keep it in TP only or not let it ride with 14.1.

Tried digging around a bit in the mirrored source at https://github.com/WebKit/WebKit, but didn't come to a firm assertion, since I couldn't figure out which branch actually is 14.1.

But I guess the changes weren't ported to 14.1 and will only come with the next version, be that 14.2 or 15.

If that's the case I'm afraid we have to wait for that next version, unless you manage to convince BCD to track Safari TP…

@surma
Copy link
Author

surma commented May 11, 2021

Just to double-check: There’s no way to set the flag for Safari TP (which currently reads “unknown”) unless BCD starts tracking it?

@Schweinepriester
Copy link
Contributor

I'm afraid so :/

As of 2020-03-24 per mdn/browser-compat-data#4840 (comment) where I asked how to track TP:

We're recording the Safari <-> TP mappings in #2991 but are aren't planning to support the TP browser or it's versions in BCD. We only support browsers released to end users and no nightlies, canaries or TPs.
We don't have the bandwidth.

Dug a bit and found more recent comments, stating the same:
mdn/browser-compat-data#8805 (comment)
=> mdn/browser-compat-data#8103 (comment)

@surma
Copy link
Author

surma commented May 11, 2021

Aw shame. I was hoping caniuse had some form of override over the BCD data. Oh well, I’ll come back once it’s in stable ;) Thanks for all your help!

@surma surma closed this as completed May 11, 2021
@Schweinepriester
Copy link
Contributor

Sure :)

I was hoping caniuse had some form of override over the BCD data

I mean… good feature request for caniuse! Do you want to create the issue? 0:-)

@Fyrd
Copy link
Owner

Fyrd commented May 12, 2021

Funny you should bring this up, since a PR just got made at BCD to add support for Safari TP (and other preview browsers) :
mdn/browser-compat-data#10334
So should be able to update it there soon!

As for overriding, not a bad idea. Assuming that would be specific for browsers tracked on caniuse and not BCD, ideally there shouldn't be a need to override support data. :)

@Schweinepriester
Copy link
Contributor

Damn, I should have been able to find that…

Great news though! :)
Once preview browsers are available the desire to override indeed largely vanishes I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants