RoomMessageEvent: refactored boilerplate code; added support of HTML-formatted messages #17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This breaks compatibility and is massive in itself, hence a PR.
While a lot of code has been moved around, it boils down to the following 5 things:
{Type}EventContent
classes have moved to a dedicated namespace (MessageEventContent
), to save on typestrokes.body
member variable is nowplainBody
and lives inRoomMessageEvent
, right next tomsgtype
. A primitive client can use these two and live in plain text - without looking atRoomMessageEvent::content()
at all.formatted_body
. The same class also can read frombody
and try to deduce the content type using Qt facilities. This may look controversial but in the end you always haveRoomMessageEvent::plainBody()
for fallback.