Adds associated functions for handling of indentation #1911
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kayagokalp
reviewed
Jun 8, 2022
Member
kayagokalp
left a comment
kayagokalp
left a comment
There was a problem hiding this comment.
this looks good to me, i.e I think we have everything we need for unblocking the implementation of the logic for say enums here.
So I think this will give us a strong base (if not the whole thing) for indentation handling. I will defer to @mitchmindtree or @JoshuaBatty for the final approval.
Contributor
Author
@kayagokalp does this close #1888 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Associated to issue #1888
This should give us the methods we need to handle indentation in the new formatter.
This also adds a
utilsfolder that will house the associated functions for organizational purposes.