Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI does not fail with failing forc-test unit-tests #4409

Closed
kayagokalp opened this issue Apr 6, 2023 · 0 comments · Fixed by #4417
Closed

CI does not fail with failing forc-test unit-tests #4409

kayagokalp opened this issue Apr 6, 2023 · 0 comments · Fixed by #4417
Assignees
@kayagokalp
Labels
ci forc-test Everything related to the `forc-test` lib and `forc test` command. P: critical Should be looked at before anything else

Comments

@kayagokalp
Copy link
Member

Reported by @sdankel:

forc-unit tests step in the CI is not blocking/failing if the unit-tests actually fail to pass. It can be seen from https://github.com/FuelLabs/sway/actions/runs/4625144956/jobs/8180631205 as we actually have failing unit tests there. Looking into it in detail after #4336 we had two unit tests failing but left unnoticed as CI did not blocked it.
@kayagokalp kayagokalp added ci P: critical Should be looked at before anything else forc-test Everything related to the `forc-test` lib and `forc test` command. labels Apr 6, 2023
@kayagokalp kayagokalp self-assigned this Apr 10, 2023
This was referenced Apr 10, 2023
Closed
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kayagokalp kayagokalp

Labels
ci forc-test Everything related to the `forc-test` lib and `forc test` command. P: critical Should be looked at before anything else
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: forc-test exits with non-zero status code if there are failing tests FuelLabs/sway
1 participant
@kayagokalp