diff --git a/fuel-block-producer/Cargo.toml b/fuel-block-producer/Cargo.toml index 1a12c2dbad1..fce145993c3 100644 --- a/fuel-block-producer/Cargo.toml +++ b/fuel-block-producer/Cargo.toml @@ -26,5 +26,4 @@ rand = "0.8" rstest = "0.15" [features] -p2p = ["fuel-txpool/p2p"] test-helpers = ["fuel-core-interfaces/test-helpers"] diff --git a/fuel-block-producer/tests/integration.rs b/fuel-block-producer/tests/integration.rs index c9e1e091f06..86e804b9fba 100644 --- a/fuel-block-producer/tests/integration.rs +++ b/fuel-block-producer/tests/integration.rs @@ -134,11 +134,8 @@ async fn block_producer() -> Result<()> { .txpool_sender(TxPoolSender::new(txpool_sender)) .txpool_receiver(txpool_receiver); - #[cfg(feature = "p2p")] - { - let (p2p_request_event_sender, _p2p_request_event_receiver) = mpsc::channel(100); - txpool_builder.network_sender(p2p_request_event_sender); - } + let (p2p_request_event_sender, _p2p_request_event_receiver) = mpsc::channel(100); + txpool_builder.network_sender(p2p_request_event_sender); let txpool = txpool_builder.build().unwrap(); txpool.start().await?; diff --git a/fuel-core/Cargo.toml b/fuel-core/Cargo.toml index bb6c9467838..e2b46ba8d8e 100644 --- a/fuel-core/Cargo.toml +++ b/fuel-core/Cargo.toml @@ -88,6 +88,6 @@ metrics = ["dep:fuel-metrics"] default = ["rocksdb", "metrics", "debug"] debug = ["fuel-core-interfaces/debug"] relayer = ["dep:fuel-relayer"] -p2p = ["dep:fuel-p2p", "fuel-txpool/p2p", "fuel-block-producer/p2p"] +p2p = ["dep:fuel-p2p"] # features to enable in production, but increase build times production = ["rocksdb?/jemalloc"] diff --git a/fuel-core/src/service/modules.rs b/fuel-core/src/service/modules.rs index da1cb4eaf69..c5ed701300f 100644 --- a/fuel-core/src/service/modules.rs +++ b/fuel-core/src/service/modules.rs @@ -103,7 +103,7 @@ pub async fn start_modules(config: &Config, database: &Database) -> Result Result Result>, @@ -36,7 +36,6 @@ pub struct ServiceBuilder { tx_status_sender: Option>, import_block_receiver: Option>, incoming_tx_receiver: Option>, - #[cfg(feature = "p2p")] network_sender: Option>, } @@ -56,7 +55,6 @@ impl ServiceBuilder { tx_status_sender: None, import_block_receiver: None, incoming_tx_receiver: None, - #[cfg(feature = "p2p")] network_sender: None, } } @@ -103,7 +101,6 @@ impl ServiceBuilder { self } - #[cfg(feature = "p2p")] pub fn network_sender( &mut self, network_sender: mpsc::Sender, @@ -136,7 +133,6 @@ impl ServiceBuilder { return Err(anyhow!("One of context items are not set")) } - #[cfg(feature = "p2p")] if self.network_sender.is_none() { return Err(anyhow!("P2P network sender is not set")) } @@ -151,7 +147,6 @@ impl ServiceBuilder { tx_status_sender: self.tx_status_sender.unwrap(), import_block_receiver: self.import_block_receiver.unwrap(), incoming_tx_receiver: self.incoming_tx_receiver.unwrap(), - #[cfg(feature = "p2p")] network_sender: self.network_sender.unwrap(), }, )?; @@ -166,7 +161,6 @@ pub struct Context { pub tx_status_sender: broadcast::Sender, pub import_block_receiver: broadcast::Receiver, pub incoming_tx_receiver: broadcast::Receiver, - #[cfg(feature = "p2p")] pub network_sender: mpsc::Sender, } @@ -205,7 +199,6 @@ impl Context { let db = self.db.clone(); let tx_status_sender = self.tx_status_sender.clone(); - #[cfg(feature = "p2p")] let network_sender = self.network_sender.clone(); // This is little bit risky but we can always add semaphore to limit number of requests. @@ -216,10 +209,7 @@ impl Context { let _ = response.send(TxPool::includable(txpool).await); } TxPoolMpsc::Insert { txs, response } => { - #[cfg(feature = "p2p")] let _ = response.send(TxPool::insert_with_broadcast(txpool, db.as_ref().as_ref(), tx_status_sender, network_sender, txs).await); - #[cfg(not(feature = "p2p"))] - let _ = response.send(TxPool::insert(txpool, db.as_ref().as_ref(), tx_status_sender, txs).await); } TxPoolMpsc::Find { ids, response } => { @@ -360,11 +350,8 @@ pub mod tests { .txpool_sender(txpool_sender) .txpool_receiver(txpool_receiver); - #[cfg(feature = "p2p")] - { - let (network_sender, _) = mpsc::channel(100); - builder.network_sender(network_sender); - } + let (network_sender, _) = mpsc::channel(100); + builder.network_sender(network_sender); let service = builder.build().unwrap(); @@ -399,11 +386,8 @@ pub mod tests { .txpool_sender(txpool_sender) .txpool_receiver(txpool_receiver); - #[cfg(feature = "p2p")] - { - let (network_sender, _) = mpsc::channel(100); - builder.network_sender(network_sender); - } + let (network_sender, _) = mpsc::channel(100); + builder.network_sender(network_sender); let service = builder.build().unwrap(); service.start().await.ok(); @@ -489,11 +473,8 @@ pub mod tests { .txpool_sender(txpool_sender) .txpool_receiver(txpool_receiver); - #[cfg(feature = "p2p")] - { - let (network_sender, _) = mpsc::channel(100); - builder.network_sender(network_sender); - } + let (network_sender, _) = mpsc::channel(100); + builder.network_sender(network_sender); let service = builder.build().unwrap(); service.start().await.ok(); @@ -560,11 +541,8 @@ pub mod tests { .txpool_sender(txpool_sender) .txpool_receiver(txpool_receiver); - #[cfg(feature = "p2p")] - { - let (network_sender, _) = mpsc::channel(100); - builder.network_sender(network_sender); - } + let (network_sender, _) = mpsc::channel(100); + builder.network_sender(network_sender); let service = builder.build().unwrap(); service.start().await.ok(); diff --git a/fuel-txpool/src/txpool.rs b/fuel-txpool/src/txpool.rs index 8a64b9cf519..0a1f5b2cfaf 100644 --- a/fuel-txpool/src/txpool.rs +++ b/fuel-txpool/src/txpool.rs @@ -29,9 +29,7 @@ use tokio::sync::{ RwLock, }; -#[cfg(feature = "p2p")] use fuel_core_interfaces::p2p::P2pRequestEvent; -#[cfg(feature = "p2p")] use tokio::sync::mpsc; #[derive(Debug, Clone)] @@ -150,7 +148,6 @@ impl TxPool { Ok(()) } - #[cfg(feature = "p2p")] pub async fn insert_with_broadcast( txpool: &RwLock, db: &dyn TxPoolDb,