New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve wallet path handling #49

Closed

kayagokalp opened this issue Sep 22, 2022 · 1 comment

Assignees

Labels

Member

kayagokalp commented Sep 22, 2022

Currently in nearly each command handling function, we have something like

let wallet_path = match &path {
  Some(path) => PathBuf::from(path),
  None => home::home_dir().unwrap().join(DEFAULT_WALLETS_VAULT_PATH),
}

We can clean it by having a util function for this, more details can be found at #47 (comment)

kayagokalp added the code quality label

kayagokalp self-assigned this

kayagokalp mentioned this issue

feat: Moved --export to a seperate export command #47

Merged

Member Author

kayagokalp commented Oct 3, 2022

I believe this is closed by #51 as it introduced handle_vault_path() util function.

kayagokalp closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment